Problem/Motivation

Make tests for UI patterns sources from the main module.

Remaining tasks

  • Test derived sources (field properties, derivable contexts)
  • Test rendering : verify entity context is correctly required and handled (and correctly passed through to the data it may retrieve, if revelant). Verify the compatibility with prop types and the returned data. Verify conversion is working.

Following Sources needs test data fixtures are needed

  • AttributesWidget
  • CheckboxWidget
  • ListTextareaWidget
  • NumberWidget
  • PathSource
  • SelectWidget
  • UrlWidget
  • WysiwygWidget
  • EntityFieldSource
  • EntityLinksSource
  • FieldPropertySource

Following Sources needs test needs extra data to work and my be tested in functional test

  • BreadcrumbSource
  • BlockSource

Issue fork ui_patterns-3467657

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

just_like_good_vibes created an issue. See original summary.

christian.wiedemann’s picture

christian.wiedemann commented
Issue summary: View changes
christian.wiedemann’s picture

christian.wiedemann commented
Issue summary: View changes
christian.wiedemann’s picture

christian.wiedemann commented
Issue summary: View changes
christian.wiedemann’s picture

christian.wiedemann commented
Issue summary: View changes
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » just_like_good_vibes

i take this one too

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Title: [2.0.0-beta2] Sources: Tests » [2.0.0-beta3] Sources: Tests

postponed to beta3

just_like_good_vibes opened merge request !221

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

Hello,
i am still adding source tests in the MR, in progress ...
still missing tests for those sources : 

BreadcrumbSource.php
ListTextareaWidget.php
MenuSource.php
NumberWidget.php
PathSource.php
SelectWidget.php
UrlWidget.php
WysiwygWidget.php
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

Also, in this MR :

- redistributed the tests between modules "ui_patterns_field_formatters" and "ui_patterns_latyouts"
- cleaned some files in tests, now unused
- update a component in test module "ui_pattterns_test"

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » christian.wiedemann
Status: Active » Needs review

finally... please review :)

a few items may be missing :

- Test of BreadcrumbSource
- Test of DerivableContext deriver

christian.wiedemann’s picture

christian.wiedemann commented
Status: Needs review » Fixed
christian.wiedemann’s picture

christian.wiedemann commented
Assigned: christian.wiedemann » Unassigned
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
pdureau’s picture

pdureau commented
Status: Fixed » Closed (fixed)