Problem/Motivation
Once POC fixed the bug, I can't reproduce the bug when stashing my changes.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork ui_patterns-3465453
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
grimreaperMR created, but let's wait if I or someone else manage to reproduce the bug.
Comment #5
pdureau commentedI will have a look
Comment #6
pdureau commented@grimreaper, OK with that? If yes, let's ask Steven to review and to confirm the usefulness of such a change.
Comment #7
grimreaperOk with the change.
But PHPMD and PHPStan also caught what I saw in my code review ;)
Comment #8
pdureau commentedSorry for this stupid mistake. I have amended the commit.
The work may not be not over anyway:
So, I will test that
Comment #9
pdureau commented2 big changes:
1
I have added Steven's example to the test cases and I understood the normalization of
link_attributeswas not happenig at the right place.Preventing the possibility of defining link_attributes manually in presenter templates:
https://git.drupalcode.org/project/ui_patterns/-/merge_requests/166/diff...
2
I have improved the management of
link_attributesby merging existing values with the ones extracted from the Url objects.And I removed the transformation of
Attributeobjects to arrays, because SDC is not complaining anymore about that. Maybe because PropTypeInterface::normalize() now happens after the SDC validator is run.https://git.drupalcode.org/project/ui_patterns/-/merge_requests/166/diff...
Comment #11
pdureau commentedComment #13
pdureau commented