Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
like we do for view in issue [2.0.0-beta1] Do we take care of the big object in views config?, we need to correct the field formatter plugins to correctly inject data through context instead of storing big data in component settings passed to rendering.
There is an issue about field formatter "ComponentFormatter" when used in a nested slot, using data from a field.
When the field has multiple values, it does render multiple component instead of one
There are multiple issues in the current codebase about contexts.
- field formatters in views do not always behave as expected.
- when componentFormatter and Component Formatter per item are nested inside each other, the behavior about the field items rendered is not as expected, and moreover when using "data from a field"
- other weird behaviors and cases, mostly based on contexts and multiple VS single value fields.
Issue fork ui_patterns-3465264
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
just_like_good_vibesOk, done.
I have added also some bonus :
- i fixed a bug in the context injected by field formatter, especially when used in views, where the bundle is unknown and set to empty string in our case.
- i refactored UI patterns views, to remove the existing service and use a trait for both row and style plugins. i fixed a few existing bugs in the codebase, especially related to view displays and default/overridden options.
- i added a new option to ViewRows source, that allows to use view rows as source, with a specific field only.
Comment #4
pdureau commentedComment #5
pdureau commentedDemo with DSFR's tabs:
Demo with Bootstrap's table:
Undefined array key "#ajax_url" in Drupal\ui_patterns\Element\ComponentForm::buildPropsForm()Also, careful with field label, if it is the displayed label from view field, it may not be useful to show it.
Comment #6
just_like_good_vibesplease test again, should be better ;)
Comment #7
pdureau commentedComment #8
pdureau commentedpulled. And rebased from 2.0.x
During configuration
Seems OK but ComponentFormatter is available in the sources selector also for single value fields (like "title"). If selected, nothing happens. The plgin from is not displayed
After configuration, looking at the result
White screen of death:
TypeError: Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::checkContextSanity(): Argument #3 ($bundle) must be of type string, null given, called in modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php on line 244 in Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase->checkContextSanity() (line 282 of modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php).Comment #9
just_like_good_vibesafter testing more, adding a few new tests,
i did some improvements on other edge cases.
it is supposed to be fine now :)
please review Pierre.
adding tests is really cool, i think we need really a lot of them.
Comment #10
pdureau commentedComment #11
just_like_good_vibesComment #12
just_like_good_vibesComment #13
just_like_good_vibesHello,
i have updated a little bit the title and description of the issue, which is now solving more problems than initially expected...
MR is rebased and fully green now :)
Comment #14
pdureau commentedUnfortunately, I will not be able to review today. you can merge yourself.
Comment #16
just_like_good_vibesComment #17
pdureau commented