------ --------------------------------------------------------------------------------------------------------------------- 
  Line   modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php                      
 ------ --------------------------------------------------------------------------------------------------------------------- 
  197    Parameter #2 $bundle of method                                                                                       
         Drupal\Core\Entity\EntityFieldManagerInterface::getFieldDefinitions()                                                
         expects string, int|string|null given.                                                                               
  205    Method                                                                                                               
         Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::findEntityBundleWithField()  
         should return string but returns int|string|null.                                                                    
 ------ --------------------------------------------------------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php                    
 ------ -------------------------------------------------------------------------------------------------------------- 
  256    Method                                                                                                        
         Drupal\ui_patterns_field_formatters\Plugin\UiPatterns\Source\FieldFormatterSource::createInstanceFormatter()  
         should return Drupal\Core\Field\FormatterBase but returns object.                                             
  282    Cannot access offset 'label' on                                                                               
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.                                           
  384    Negated boolean expression is always false.                                                                   
         💡 Because the type is coming from a PHPDoc, you can turn off this                                            
            check by setting treatPhpDocTypesAsCertain: false in your                                                  
            phpstan.neon.                                                                                              
 ------ -------------------------------------------------------------- 
  Line   modules/ui_patterns_layouts/ui_patterns_layouts.module        
 ------ -------------------------------------------------------------- 
  21     Cannot access offset 'annotated_name' on                      
         Drupal\Core\Theme\Component\ComponentMetadata.                
  21     Cannot access offset 'id' on                                  
         Drupal\Core\Theme\Component\ComponentMetadata.                
  21     Cannot access offset 'name' on                                
         Drupal\Core\Theme\Component\ComponentMetadata.                
  22     Cannot access offset 'group' on                               
         Drupal\Core\Theme\Component\ComponentMetadata.                
  23     Cannot access offset 'provider' on                            
         Drupal\Core\Theme\Component\ComponentMetadata.                
  25     Cannot access offset 'id' on                                  
         Drupal\Core\Theme\Component\ComponentMetadata.                
  27     Cannot access offset 'slots' on                               
         Drupal\Core\Theme\Component\ComponentMetadata.                
  33     Cannot access offset 'icon_map' on                            
         Drupal\Core\Theme\Component\ComponentMetadata.                
  36     Cannot access offset 'icon_path' on                           
         Drupal\Core\Theme\Component\ComponentMetadata.                
  39     Cannot access offset 'id' on                                  
         Drupal\Core\Theme\Component\ComponentMetadata.                
  39     Possibly invalid array key type (array<int, string>|string).  
 ------ -------------------------------------------------------------- 
 
 ------ ---------------------------------------------------------------------------- 
  Line   modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewFieldSource.php  
 ------ ---------------------------------------------------------------------------- 
  71     Negated boolean expression is always false.                                 
         💡 Because the type is coming from a PHPDoc, you can turn off this          
            check by setting treatPhpDocTypesAsCertain: false in your                
            phpstan.neon.                                                            
 ------ ---------------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------------- 
  Line   modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewsSourceBase.php  
 ------ ---------------------------------------------------------------------------- 
  83     Left side of && is always true.                                             
         💡 Because the type is coming from a PHPDoc, you can turn off this          
            check by setting treatPhpDocTypesAsCertain: false in your                
            phpstan.neon.                                                            
  83     Parameter #1 $key of method                                                 
         Drupal\Core\TempStore\SharedTempStore::get() expects string,                
         int|string|null given.                                                      
 ------ ---------------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------------- 
  Line   modules/ui_patterns_views/src/Plugin/views/row/ComponentRow.php              
 ------ ----------------------------------------------------------------------------- 
  83     Method                                                                       
         Drupal\ui_patterns_views\Plugin\views\row\ComponentRow::buildOptionsForm()   
         has parameter $form with no type specified.                                  
  101    Method                                                                       
         Drupal\ui_patterns_views\Plugin\views\row\ComponentRow::submitOptionsForm()  
         has parameter $form with no type specified.                                  
  109    Property Drupal\views\Plugin\views\PluginBase::$options (array) on           
         left side of ?? is not nullable.                                             
 ------ ----------------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------------- 
  Line   modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php             
 ------ -------------------------------------------------------------------------------- 
  87     Method                                                                          
         Drupal\ui_patterns_views\Plugin\views\style\ComponentStyle::buildOptionsForm()  
         has parameter $form with no type specified.                                     
 ------ -------------------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   modules/ui_patterns_views/src/UiPatternsViewsManager.php             
 ------ --------------------------------------------------------------------- 
  45     Cannot access offset 'plugin_type' on                                
         array|Drupal\Component\Plugin\Definition\PluginDefinitionInterface.  
 ------ --------------------------------------------------------------------- 

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Issue summary: View changes
pdureau’s picture

Assigned: Unassigned » just_like_good_vibes
pdureau’s picture

Title: [2.0.0-beta2] Code quality: Consumer plugins » [2.0.0-beta1] Code quality: Consumer plugins

just_like_good_vibes made their first commit to this issue’s fork.

just_like_good_vibes’s picture

Status: Active » Needs review

let's review :)

just_like_good_vibes’s picture

Status: Needs review » Fixed
just_like_good_vibes’s picture

just_like_good_vibes’s picture

Assigned: just_like_good_vibes » Unassigned
pdureau’s picture

Status: Fixed » Closed (fixed)