Problem/Motivation

During the conversion the links are turned into

links:
  - 'https://designsystem.digital.gov/components/combo-box/'

But the code in the templates

{% if component.links %}
    <div class="ui_patterns_component__links">
      {% if component.links|length > 1 %}
        {{ "Links:"|t }}
        <ul>
          {% for link in component.links %}
            <li class="ui_patterns_component__link">
              <a href="{{ link.url }}">{{ link.title|default("Documentation") }}</a>
            </li>
          {% endfor %}
        </ul>
      {% else %}
        <p class="ui_patterns_component__link">
          <a class="usa-button" href="{{ links[0].url }}">{{ links[0].title|default("Documentation") }}</a>
        </p>
      {% endif %}
    </div>
  {% endif %}

Expect a url and title key

Steps to reproduce

Proposed resolution

Remove need of url / title key

Or update links conversion.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

pdureau’s picture

Status: Active » Postponed

let's wait #3438360: Use Drupal entities & plugins for the Library pages before doing anything

Maybe a field formatter plugin will fix that

pdureau’s picture

Title: External links do not work » [2.0.0-beta2] External links do not work
pdureau’s picture

Component: Code » UI Patterns Library
pdureau’s picture

Assigned: Unassigned » pdureau

  • pdureau committed 852abf66 on 2.0.x
    Issue #3462146 by pdureau, smustgrave: Fix external links in libray...
pdureau’s picture

Assigned: pdureau » Unassigned
Status: Postponed » Fixed
pdureau’s picture

Status: Fixed » Closed (fixed)