Proposals:

  • Remove "Field" from fields select list
  • Order fields by alphabetical order of labels
  • Don't repeat the field name in the fieldset (do we even need a fieldset here?)

CommentFileSizeAuthor
#8 Bildschirmfoto vom 2024-07-22 23-19-50.png52.17 KBchristian.wiedemann
#2 Capture d’écran du 2024-07-15 22-25-32.png18.54 KBpdureau
Capture d’écran du 2024-07-15 22-25-32.png18.54 KBpdureau

Issue fork ui_patterns-3461579

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue summary: View changes
StatusFileSize
new Capture d’écran du 2024-07-15 22-25-32.png18.54 KB
pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented
Assigned: Unassigned » christian.wiedemann

Christian.wiedemann made their first commit to this issue’s fork.

pdureau’s picture

pdureau commented

When i say:

Remove "Field" from fields select list

I mean, going from "Field Title" to "Title", from "Field Body" to "Body". We already know it is a field.

Christian.wiedemann opened merge request !151

christian.wiedemann’s picture

christian.wiedemann commented
Status: Active » Needs review
StatusFileSize
new Bildschirmfoto vom 2024-07-22 23-19-50.png52.17 KB

* I removed the title from the fieldset
* Sort the field.
* Remove the field from the list

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

hello,
about the change in " src/Plugin/Derivative/EntityFieldSourceDeriverBase.php " in the current MR 

-            'label' => $this->t("Field @field", ["@field" => $field_data["label"]]),
+            'label' => $this->t("@field", ["@field" => $field_data["label"]]),

it may be better to update the label inside child class of EntityFieldSourceDeriverBase class instead of this base class,
because it may have implications on all source plugin derivers.
Here you just wanted to update the "DerivableContextDeriver" right? then you can update the label of derived plugins in that class directly :)

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

And that would be interesting also to remove the fieldset (e.g. in that usage of slotForm or propForm)
the simpler the better :) ?

pdureau’s picture

pdureau commented

I only care about the wording results, if you agree on a simpler way of doing that, let's go :)

christian.wiedemann’s picture

christian.wiedemann commented

@just_like_good_vibes
* I added functions which can be overwritten by sub classes. Not sure if it is too much. But now it is easy to change the title, description in sub classes.
* I also prefer container but we should do this in the big UI refactor update.

pdureau’s picture

pdureau commented
Assigned: christian.wiedemann » just_like_good_vibes

I also want to review before the merge

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

Hello, i did not understand your previous comment Pierre,
maybe your assigned me as a mistake?
anyway, i checked the content of the MR. what is done seems visually ok, although i did not tested myself the code.

pdureau’s picture

pdureau commented
Assigned: just_like_good_vibes » pdureau

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.