What was not done in #3445079: [2.0.0-alpha2] Feedbacks about Views module

View style

View rows: empty renderable even when results Status : fix

❌ I still see the issue:

  1. I create a view of articles. I have at least one published article in my site.
  2. I chose "Component (UI Patterns)" as view style & "content: teaser" as view rows
  3. I chose Bootstrap 5's Alert components and I put "View rows" source in the message slot
  4. I save the view
  5. FAIL: I don't see the rows in front

But, if I add another source in the same slot of an other slot, it appears ! So it may be a cache issue.

Let's talk about that in Alpha3.

TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): error should appear only when you choose ui patterns views plugins inside views (the first time when choose on the radios button "Component (UI patterns)", this error seems to be related to views, for example with better exposed filter I'v got the same issue (enable BEF, expose pager, select the BEF plugin, the select of pager ajax not working at the first popup ) I try to debug but it's very complicated, I think I will try to resolve this at the end of develop. I also started an issue on Core https://www.drupal.org/project/drupal/issues/3447838

Let's follow this in alpha3.

View row

The view fields are not available as sources for slots. Status : fix

❌ I have this issue:

Call to undefined method Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource::getSettings() in Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource

Architecture

Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

Let's talk about that in Alpha3.

Issue fork ui_patterns-3449932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented

Also:

  ------ ---------------------------------------------------------------------------------------- 
  Line   ui_patterns/modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewFieldSource.php  
 ------ ---------------------------------------------------------------------------------------- 
  108    Call to an undefined method                                                             
         Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource::getSettings().       
 ------ ----------------------------------------------------------------------------------------
pdureau’s picture

pdureau commented

Was also find in ui_patterns_blocks:

TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): Argument #1 ($component_id) must be of type string, null given, called in src/Element/ComponentElementBuilder.php on line 40 in Drupal\Core\Theme\ComponentPluginManager->find() (line 133 of /core/lib/Drupal/Core/Theme/ComponentPluginManager.php).

It was fixed by injecting the component_id to the renderabel builder:

-    $build = $this->buildComponentRenderable();
+    $build = $this->buildComponentRenderable($component_id);
pdureau’s picture

pdureau commented

About the cache issue, have a look on SourceInterface::alterComponent()

Musa.thomas made their first commit to this issue’s fork.

musa.thomas’s picture

musa.thomas
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » musa.thomas
pdureau’s picture

pdureau commented
Component: Code » UI Patterns Views

Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

Moved to its own beta1 ticket: #3452481: [2.0.0-beta1] Do we take care of the big object in views config?

Musa.thomas changed the visibility of the branch 2.0.x to hidden.

musa.thomas’s picture

musa.thomas
Primary language French
Location France 🇫🇷
commented
Status: Active » Fixed

Didn't reproduce the problem of cache

musa.thomas’s picture

musa.thomas
Primary language French
Location France 🇫🇷
commented
Status: Fixed » Closed (cannot reproduce)