Problem/Motivation

Original GH issue:
Original GH PR: https://github.com/nuvoleweb/ui_patterns/pull/336
Follow (github) : https://github.com/nuvoleweb/ui_patterns/pull/284
Follow (drupal.org) : #3311455: Support field_groups nesting

"No description provided."

Issue fork ui_patterns-3314998

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

G4MBINI created an issue. See original summary.

G4MBINI credited DuaelFr.

g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
g4mbini’s picture

g4mbini
Primary language French
Location Ruvo di Puglia (BA)
commented
Related issues: +#3311455: Support field_groups nesting

Pallavi1620 made their first commit to this issue’s fork.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Needs work
Issue tags: +Needs tests

Code from github has been brought back.
MR opened against #3311455: Support field_groups nesting
Still need tests

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

I don't know why but the MR is unavailable
https://git.drupalcode.org/issue/ui_patterns-3314998/-/merge_requests/1

Maybe we need to wait until #3311455: Support field_groups nesting is fixed to be able to see it...

In the meantime if you need this in your project, here is the commit and the patch.

Grimreaper opened merge request !16

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

I manually went on the fork and created the MR.

Sometimes when there are underscores or special characters in the issue title, the proposed commands do not work out-of-the-box.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

I think the problem was that the MR was created against another MR and not the base branch.
This one shouldn't be merged before #3311455: Support field_groups nesting

pdureau’s picture

pdureau commented
Component: Code » UI Patterns Field Group [1.x only]

  • duaelfr committed b0572347 on 8.x-1.x authored by grimreaper 
    Issue #3314998 by duaelfr, Pallavi1620, g4mbini: Allow to use...
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs work » Fixed

Existing tests are stable. Let's merge this before moving on to the next major.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.