Problem/Motivation

Hi,

I am porting Ui Patterns from Github to Drupal.org and enabling automated testing on Drupal.org, It catched a regression.

After some investigations, it is related to a change in how the config is stored by Field Group.

I am still doing investigations to isolate exactly from where this is coming from and to provide examples before/after.

8.x-2.2:

third_party_settings:
  field_group:
    group_aaaa:
      children:
        - body
      label: aaaa
      parent_name: ''
      region: content
      weight: 2
      format_type: pattern_formatter
      format_settings:
        pattern: metadata
        pattern_mapping:
          'fields:body':
            destination: field_1
            weight: 0
            plugin: fields
            source: body
        show_empty_fields: 0
        pattern_variant: first

8.x-3.3:

third_party_settings:
  field_group:
    group_aaaa:
      children:
        - body
      label: aaaa
      parent_name: ''
      region: content
      weight: 2
      format_type: pattern_formatter
      format_settings:
        pattern: metadata
        variants:
          metadata: first
        pattern_mapping:
          metadata:
            settings:
              'fields:body':
                destination: field_1
                weight: '0'
        show_empty_fields: 0

Steps to reproduce

Configure a field group to be rendered as a pattern.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

Issue summary: View changes

Providing example of config structure change.

grimreaper’s picture

Ok, I found which change in Field Group provokes that:

https://git.drupalcode.org/project/field_group/-/commit/8c9fcd4499cd6791...

grimreaper’s picture

Or it can also come from https://git.drupalcode.org/project/field_group/-/commit/dbdf8ba3962b4f85...

With the introduction of the field_group_module_implements_alter() hook.

Grimreaper credited GoZ.

grimreaper’s picture

Title: Config structure change after upgrading to 8.x-3.3 » Config structure change after upgrading Field Group to 8.x-3.3
Project: Field Group » UI Patterns (SDC in Drupal UI)
Version: 8.x-3.3 » 8.x-1.x-dev

  • Grimreaper committed 0aae8d8 on 8.x-1.x
    Issue #3310657 by Grimreaper, GoZ: Config structure change after...
  • Grimreaper committed ffd5bc6 on 8.x-1.x
    Issue #3310657 by Grimreaper: Fix hardcoded module path in tests.
    

  • Grimreaper committed f1bd143 on 8.x-1.x
    Issue #3310657 by Grimreaper: Handle subdirectory for links in tests.
    
grimreaper’s picture

Assigned: grimreaper » Unassigned
Status: Active » Fixed
goz’s picture

Issue tags: +Prague2022
g4mbini’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.