Closed (fixed)
Project:
Ubercart securepay.com.au Payment Gateway
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Feb 2013 at 10:29 UTC
Updated:
1 Aug 2013 at 17:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
dgtlmoon commentedFirst attempt attached here
NOTE: I have dropped support for the reoccuring/registered accounts payments, this is a single-hit payment method only, once the maintainers come back to life or I get access to the project we'll lock this is as 7.x and build it back up
also incorporates patch from #1542886: does not properly pass cvv information to payment gateway
Comment #2
dgtlmoon commentedOops, always the way, fixed a glitch in $order->currency handling
Comment #3
rooby commentedNice, I was going to do this, so I will definitely try it out soon.
I will be needing recurring support though so I will look at adding that once I have tried it out.
Comment #4
dgtlmoon commentedGreat! I've removed the handling of different txn_type's so you'll need to trace it through from the top and compare it against the D6 version.
Perhaps move the recurring related functions into their own include file to keep it clean
Comment #5
univate commentedGreat stuff D7 port of this module is long overdue...
Why disable the currency support? Its a useful feature to have since securepay actually supports this really easily if you have a NAB multi-currency account. Although the project I used this on only cared about USD support, so I didn't expand the list here to include all currencies that securepay/NAB can support.
The core API For uc_recurring has not changed for D7 (I know as I am the maintainer for uc_recurring) - so this should all be able to be added and hopefully just work. Not against the idea of splitting into a separate file for maintenance reasons.
Comment #6
decipheredPatch didn't apply, so I re-rolled it and took the comments from #5 into account.
I was investigating using uc_recurring, but it turned out that it's unlikely to meet my clients needs, so while there is at least one minor fix for that functionality, I can't confirm that it is all working.
Comment #7
dgtlmoon commentedYour patch was almost identical to something I had, comitted and formed new 7.x-dev branch