The current state of UCRecurring seems to sadly lack in its support of Paypal. Namely:
1) It is possible to buy subscriptions through WPS, but WPS has its limits for when there are several subscriptions to be created at once.
2) It is possible to buy subscriptions through WPP, but WPP doesn't work with paypal login - it only applies to credit cards.
Here is my attempt to solve the situation in the form of a fee handler for Express Checkout payment method.
(the files in attach are full module files rather than patchfiles; 1.1.4 was used as the basis)
Several problems exist:
1) The cancellation of subscription doesn't really work due to it being copypaste from WPS code.
2) Orders containing non-recurring items will possibly be stuck to Pending due to an obscure bug with drupal/ubercart handling of paypal NVP
3) There is a 10 recurring items limit when using EC.
4) EC needs to submit the recurring information on the very first SetExpressCheckout request, so UC Paypal module needs to be modified as well. If anyone has ideas on how to override this without altering UC itself? In this case that also applies to 3) since i'm not sure if it's possible to redirect user back to cart from the checkout while inside of uc_recurring.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | uc_recurring-express_checkout.patch | 14.99 KB | univate |
| #4 | uc_recurring_hosted.904074.patch | 15.21 KB | torgospizza |
| #3 | uc_paypal.module.904074.patch | 4.68 KB | torgospizza |
| #3 | uc_recurring_hosted.904074.patch | 79.96 KB | torgospizza |
| uc_paypal.module.txt | 47.28 KB | anarchid |
Comments
Comment #1
univate commentedPlease post patches, its impossible to review changes, when I can't see what you are changing.
http://drupal.org/patch/create
Comment #2
geerlingguy commentedSubscribe.
Comment #3
torgospizzaHere are patches based on the new module. Keep in mind the uc_recurring_hosted patch is based on the current stable, not the current dev, which has some refactoring in it that may alter the way this patch applies, so the changes here will need to be merged with latest dev if they're accepted.
I haven't tested them yet but I will. I'm putting them here so others can at least review the changes.
EDIT: See my post below this one with regard to the uc_recurring.module patch.
(Cross-posted from #781010-30: Patch to Ubercart might break recurring Paypal WPS )
Comment #4
torgospizzaScrap that uc_recurring_hosted.patch file, this one is the correct one. That was the one based on the current -dev of uc_recurring, I think. (Version number is newer.)
Attached is the one based on the current stable (alpha4).
Comment #5
univate commentedPatches will need to be against the current -dev (I have attempted to fix - untested)
Attaching patches for uc_paypal, not going to help here, they will need to be posted to ubercarts issue queue.
Comment #6
puravida commentedNote: Our previous developer, anarchid, disappeared before fully submitting these patches, so we have had to move on. As a result, we have dropped our dev support on Paypal EC and will not be focused on this part of the project moving forward.
To others that may be interested, however, anarchid's code DID work for multiple recurring items for paypal payments but it was a strange implementation. It seemed that there was a missing "parent" loop in the paypal module of ubercart (that prevented multiple recurring items) and then he modified the WPS support to basically setup a billing agreement and then put in the multiple recurring orders. I mention all of that to say that while it did work pre-alpha4 + ubercart 2.2, I doubt that it would work in later versions. Even though we were told that he got Paypal EC working, it was not by using the Paypal EC button/pane on the cart. It would require using the WPS and uc_recurring module. So it was probably a miracle that it worked and got us through a rough spot but probably won't be very helpful now.