I'm a developer and currently have 2 clients who are interested in using this module on their sites. This is a great module and it would be easier for developers like myself to contribute code back to it if it followed the Drupal coding standards.
The Coder module can automatically point out places where a module doesn't follow the coding standards, any many of the changes are easy to make.
I ran Coder on uc_discounts_alt in normal (not picky) mode and it gave 1324 warnings.
It would be great if the maintainer of this module could take some time to make it coding standards compliant. Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 541926-b.patch | 236.4 KB | ezra-g |
| #1 | 541926.patch | 236.41 KB | ezra-g |
Comments
Comment #1
ezra-g commentedThis patch uses the coder_format script to reduce the number of warnings to 15. More importantly, it makes it easier for other developers to work with this module.
Thanks!
Comment #2
ezra-g commentedThe attached patch fixes a parse error.
Comment #3
ryangroe commented"coding standards compliant"
The module follows very strict coding standards. They are just not the Drupal standards that others may be used to. I am a C++ developer and made the module easier for me to work with. If a code update does not affect functionality I would be willing to consider this but it doesn't change what the module does so this is a low priority.
Comment #4
ryangroe commentedI applied this so I apply your other patches. This will be released as beta 34.
Comment #5
echoz commentedDid the parse error fix in #2 get into the betas, because I upgraded from beta33 to beta35 and when enabling Codeless Discounts Field, get:
unexpected '{' in .../codeless_discounts_field.module on line 114
Comment #6
ryangroe commentedI'll look into it. I applied the patch in 541926-b.patch. Did I need to apply both? I'm trying to catch up here with everything else :)
Comment #7
ryangroe commentedOK, got that fixed. Grab beta 36 coming out shortly.
Comment #8
ezra-g commentedThis is committed, so it is actually fixed :).