[file-downloads] token broken in 2.4?? [#895616]

I just upgrade to 2.4. Prior to upgrade, my file downloads links were working fine once I completed an order. Now, the checkout complete page shows [file-downloads] instead of the actual file download link. I put in another token to make sure tokens are working, so I used [order-id] [file-downloads] and on my order complete page it says:

Order ID: 61 [file-downloads]

I attached a screenshot of this.

I ran all upgrades, rechecked my products (checkout works fine), made sure my permissions are ok. Everything else looks good and appears to be working. I searched and didn't see other posts on this being broken so I wonder if it's just my install? Ideas?

Comment	File	Size	Author
	checkout complete	17.37 KB	emilyf

Comments

Comment #1

emilyf commented 29 August 2010 at 13:22

Priority:

Normal

» Major

I have been trying to further debug this issue. I have found the following:

- uc_file.module, in the uc_file_token_values() function. I run some print statements in this function, and I do not get inside the case 'uc_file'. If I change that to case 'order' then the function proceeds on to print out debug statements on the order complete page. However, $values['file-downloads'] seems to be empty, or not exist at all.

- I ran print_r($object) at the top of uc_file_token_values() to look at the order object. Should the associated file download be part of this array? It does not show up for me at all, but I am not sure if it's supposed to be in there or not.

- My conditional actions are running appropriately in relation to file downloads. After completion of my order, I get the drupal message with the link to proceed to my downloads. (The reason this is not sufficient is because I don't actually want to provide this link to ALL the items they have ever downloaded, I would rather give them the direct link to what they want to download for this specific order, hence the need for the token).

- On the file downloads page, I see my download, and I see it associated with my product and correct SKU. So I know that it is attached.

- Lastly, the products I am hooking these up to are all set to 'shippable'. I'm not sure if this makes a difference, since all other aspects of this module appear to work fine other than this token, but I wanted to include this info just in case.

I hope some of this info is helpful, but I'm not sure what else I can debug before getting feedback. My store exists solely to have file downloads, so this is a pretty big issue for me. Thanks so much for any help you can provide.

Comment #2

emilyf commented 29 August 2010 at 13:23

Priority:

Major

» Normal

sorry, don't know why I set that to major. It's major for me, but not in the bigger picture of ubercart I'm sure!

Comment #3

emilyf commented 29 August 2010 at 13:31

Another update. I am even more confused because
[file-downloads] token works in the notification email that gets sent out when file access is granted.

Is this a case of a workflow issue? Should I not be putting [file-downloads] token into the checkout settings > checkout messages area because it hasn't fully processed? It seems I should be able to since I can put the other tokens there.

Comment #4

tr commented 29 August 2010 at 17:03

Is this a case of a workflow issue? Should I not be putting [file-downloads] token into the checkout settings > checkout messages area because it hasn't fully processed? It seems I should be able to since I can put the other tokens there.

I think this is probably the explanation. The file download usually isn't granted until the order status moves to complete, which in general it does not do for shippable products upon order submission because obviously you haven't shipped anything yet. There have been some threads on ubercart.org about this, and perhaps you had customized your Conditional Actions or even modified core according to someone's recipe in order to change that?