Here's the issue for all of the other fixes that the others didn't catch. http://drupal.org/node/394070 does have Multi-lingual and Miscellaneous sections, but this issue should also cover all of the changes proposed by Coder.

CommentFileSizeAuthor
#2 coder_review.patch472.19 KBIsland Usurper
#1 all-misc.patch94.71 KBIsland Usurper
#1 all-misc-merge.txt18.25 KBIsland Usurper

Comments

Island Usurper’s picture

Island Usurper commented
Status: Active » Needs work
StatusFileSize
new all-misc-merge.txt18.25 KB
new all-misc.patch94.71 KB

I've committed this patch, which includes the Multi-lingual and Miscellaneous changes. I've got the feeling that Coder is going to be continuously updated, so I want to make it a separate patch. Once we can get Ubercart to run through Coder without any critical problems, then we can mark this issue fixed.

Island Usurper’s picture

Island Usurper commented
Status: Needs work » Fixed
StatusFileSize
new coder_review.patch472.19 KB

I've committed a patch that fixes a lot of the Coder issues, but it's long, boring, and really hard to review all at once. It's because the coding standards added a space on both sides of the concatenation dot.

  print "Strings " . $like . " this.";

Coder is also returning a lot of false positives. These mostly involve functions that aren't actually implementations of hook_access(), and the flagrant use of $_SESSION. I'm fairly sure $_SESSION is only being used as it is needed, and drupal_set_session() doesn't actually exist anyway.

I attached the patch anyway, but I think it will be easier just to deal with follow-up issues as we find them.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.