Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This is a patch to add the ability to have Japanese numerical values usable for quantity input areas.
While this just covers Japan, the problem is that if someone using Japanese input, inputs a numerical value, the byte value of this numerical value does not match up. This could be expanded to more language and input formats outside of Japan.
Meaning that 1 and １ are not the same thing.
This patch will search for this and replace １ with 1 so that Japanese users don't need to worry about input of their text and what format they input in.
We will update this patch in the future to cover the admin, and do one for address input fields too, but for now this just deals with adding to cart features and adjusting quantity in the cart.
Regards,
Shaun
Alethia
www.alethiadesign.com
| Comment | File | Size | Author |
|---|---|---|---|
| ubercart_numbers.patch | 2.16 KB | Dokuro |
Comments
Comment #1
Bilmar commentedDokuro - thanks for the great work. I will be testing this patch over the weekend.
Comment #2
tr commentedIsn't this an issue that affects all of Drupal? I don't know how Japanese numerical input is normally handled in Drupal, but if the problem is not something caused by Ubercart I think it should be addressed in Drupal not in Ubercart. There are many places all over Drupal that accept numerical input - don't they all fail with Japanese numerical input?
Even if this is not the case, I think a better way to address the issue would be to create a new type of form element (i.e. implement hook_elements()) to be used instead of textfield for when numerical text is entered. That way it can be reused everywhere in Drupal or Ubercart, rather than having to add a form_validate to each and every form that wants to accept numerical text.
Comment #3
Dokuro commentedI think we need to think about the input forms of Ubercart and what Ubecart is doing. Ubercart is checking to see if 2 or ２ is a quantity. All of Drupal is not checking for quantities, so it would not apply to all of Drupal.
Comment #4
longwaveI don't consider this a bug, nobody else has requested this change, and I can't find anything else about Japanese number input in Drupal or even other PHP apps. Is this really an issue?
Comment #5
longwaveIf this is still needed, feel free to reopen with more info and/or a patch to implement it.
Comment #6
Dokuro commentedYeah, its still an issue, and to follow up on your other post. Yes, this is never really addressed outside of Japan, but still a major issue. I did include this when I was working on the Zen-Cart language pack. We use it internal for our clients. So it is good for anyone inside Japan.
I guess the best thing is leave it up to you, but at least the patch is here for anyone that wants to use this that runs into this issue as it is an issue with Japanese and people who deal with Japan.
Thanks!
Shaun