gmdate using "M" to "m" for reports [#635986]

Hi,

In uc_reports.admin.inc

l(gmdate('M Y', $month_start), 'admin/store/orders/search/results/0/0/0/0/0/0/'. $month_start .'/'. $month_end),

Change to:

l(gmdate('m Y', $month_start), 'admin/store/orders/search/results/0/0/0/0/0/0/'. $month_start .'/'. $month_end),

For international users I would like to submit the patch for reports to use "m" the numeric representation of a month as apposed to using "M" a short textual representation. This makes it more international as most cultures are able to use the numerical aspects of dates, but Jan, Feb and such are only for western areas. We needed this for Japan, but I am sure it can be used world-wide.

Included is a patch.

Regards,

Shaun

Comment	File	Size	Author
	ubercart_reports_month.patch	638 bytes	Dokuro

Comments

Comment #1

tr commented 30 December 2009 at 21:30

Status:

Needs review

» Needs work

A better fix IMO is to use format_date() instead of gmdate(). format_date() uses gmdate() under the hood, plus it localizes the text elements like month and month abbreviation, and also accounts for the timezone of the user.

I also suggest searching the rest of the Ubercart code and patching all the core modules that need patching. As long as you're addressing this issue, let's make sure it gets fixed *everywhere* in Ubercart.