uc_google_checkout.module line #1000, in function uc_google_checkout_buyer_message_request():
$output .= '<send-email>'. (module_exists('uc_notify') && variable_get('uc_notify_order_update_enabled', TRUE) ? 'true' : 'false') .'</send-email>';
The uc_notify module has been eliminated for Ubercart 2.0, so this conditional statement will always evaluate to FALSE. Likewise, the variable 'uc_notify_order_update_enabled' is no longer defined anywhere in the Ubercart code base, so the result of variable_get will depend on whether there is a legacy variable definition in your DB (e.g. left over from when the site was running Ubercart 1.x and using the uc_notify module).
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 452524_gc_notify.patch | 734 bytes | Island Usurper |
Comments
Comment #1
Island Usurper commentedThis one I'm not sure what to do with. On the one hand, I can send an email to the Google account that purchased the order, but on the other, the email connected to the Ubercart user could also get an email from the CA notification. These emails also aren't necessarily the same.
Either way, the message will appear in the buyer's Google Checkout account, so they can find it if they look.
Comment #2
rszrama commentedAt the very least we should remove the uc_notify reference. : D
Comment #3
Island Usurper commentedIs there any reason to make this a setting? I'm inclined to hard-code it as "true". It doesn't hurt to give people backups of messages they receive, I don't think.
Comment #4
Island Usurper commentedComment #5
Island Usurper commentedMeh. I guess it doesn't matter. Committed.