This is in regards to the "Store Administration->Orders->Search Orders" page. When viewing the searched order results, the table headers allow for interactivity. When clicked they show the asc or desc arrow yet the results stay static.

Could anyone point me in the right direction on how to fix this?

CommentFileSizeAuthor
#2 2001120.patch1.25 KBtr

Comments

tr’s picture

tr commented

Yeah, it looks like the sorting was never implemented on that page. The search page shares some code from admin/store/orders, and the sort headers are there because they're implemented and working on admin/store/orders. But admin/store/orders/search doesn't use tablesort_sql() so the results aren't sortable.

If you want to submit a patch for this, the function uc_order_admin() generates the results table, and uc_order_usearch() constructs the search query that's passed to uc_order_admin(). That query needs to use tablesort_sql(). Both functions are in uc_order.admin.inc.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 2001120.patch1.25 KB

Ah, it was easy enough so I just did it. Here, try this patch and let me know if it works for you.

Status: Needs review » Needs work

The last submitted patch, 2001120.patch, failed testing.

tr’s picture

tr commented
Version: 6.x-2.11 » 6.x-2.x-dev
Status: Needs work » Needs review

Random testbot failure ...

tr’s picture

tr commented

#2: 2001120.patch queued for re-testing.

mattdev’s picture

mattdev commented
Version: 6.x-2.x-dev » 6.x-2.11

Thanks TR! This worked for me :)

tr’s picture

tr commented
Status: Needs review » Fixed

OK. Committed. Thanks for the bug report.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.