When creating new content the option to "Announce this Post on Twitter" always shows up even when I have it deactivated for all content types in the Twitter Setup menu.

CommentFileSizeAuthor
#6 twitter-fix-form-alter-372970-6.patch1.23 KBwebchick
#5 twitter-fix-form-alter-372970-5.patch1.19 KBwebchick
#4 twitter-fix-form-alter-372970-4.patch1.18 KBwebchick
#3 twitter.372970-2.patch.txt602 bytesjbrauer

Comments

keva’s picture

keva commented

Having the same issue with 6.x-2.x-dev.
It's activated for only one content type, but shows up on all.
Drupal 6.9

jbrauer’s picture

jbrauer commented
Status: Active » Needs review
StatusFileSize
new twitter.372970-2.patch.txt602 bytes

Sure enough we never test for twitter_types when displaying the form.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new twitter-fix-form-alter-372970-4.patch1.18 KB

Confirmed this bug.

There were some code style issues in Josh's patch. I rolled in the fix from #365014: Improperly altering non-node forms and also moved the include line down, since there's not much point in including twitter.inc on *every* form.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new twitter-fix-form-alter-372970-5.patch1.19 KB

Now with fewer notices! Hooray!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new twitter-fix-form-alter-372970-6.patch1.23 KB

And now one that actually works! :P

Sorry. :) I was confusing myself.

jbrauer’s picture

jbrauer commented
Status: Needs review » Reviewed & tested by the community

Thanks Angie for making it a much nicer patch.... Tested and working like a champ...

eaton’s picture

eaton commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks! ;-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.