When posting to twitter, my patch is allowing user to add tracking codes to tweeted urls.

Here's the admin form :

Admin Form

The tracking codes are added to both minimized and full URL.

CommentFileSizeAuthor
#6 twitter-post-allow-to-add-tracking-to-url-2582287-6.patch4.63 KBkgaut
#2 twitter-post-allow-to-add-tracking-to-url-2582287-2.patch4.61 KBkgaut
2015-10-07-19:53:43-Screenshot.jpg56.88 KBkgaut

Comments

Kgaut created an issue. See original summary.

kgaut’s picture

kgaut commented
StatusFileSize
new twitter-post-allow-to-add-tracking-to-url-2582287-2.patch4.61 KB

Annnnd the patch !

kgaut’s picture

kgaut commented
Title: Twitter Post - Allow to add tracking get arguments » Twitter Post - Allow to add tracking arguments to URL
Status: Active » Needs review
kgaut’s picture

kgaut commented

A tweet sample that use this patch : https://twitter.com/Kgaut/status/651827674680328192

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

This needs some work to make the code match the Drupal coding standards, e.g. booleans should be in uppercase, the variable_get() call needs to have the variable name passed in as a string instead of a constant, "URL" should be uppercase, there should be a space after commas when used as a function argument separator, etc.

kgaut’s picture

kgaut commented
Status: Needs work » Needs review
StatusFileSize
new twitter-post-allow-to-add-tracking-to-url-2582287-6.patch4.63 KB

Thanks for your review.

The attached patch should fit better to the coding standards.