Fantastic work on the module! I use it on most of the sites.
One of my clients reported seeing duplicate tweets when he added a node and then edited it later on. Digging into the module, I found that the tweets were made on the node update hook as well. This is not desirable, as every minor edit would trigger duplicates.
The attached patch makes tweeting on node update configurable. It is a minor change. I am not sure why the tests are failing. Might need manual review.
Thanks,
Sumit
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | twitter-n2430229-10-6.x-5.x.patch | 2.71 KB | damienmckenna |
| #9 | twitter-n2430229-9-7.x-5.x.patch | 3.64 KB | damienmckenna |
Comments
Comment #1
sumitmadan commentedCreated a patch of a configuration. Please review.
Comment #3
sumitmadan commentedComment #4
damienmckennaComment #6
damienmckenna@sumitmadan: Thanks for the patch, I'll review it shortly.
One thing to note - please only set the "assigned" field to your name when you're continuing to work on something - it isn't for indicating who worked on something in the past, it's for indicating who's going to work on it in the future.
Comment #7
dries arnoldsTested this on two websites and works fine.
Comment #8
damienmckennaComment #9
damienmckennaI've simplified it a little bit and made it follow the same pattern as the existing default value.
Comment #10
damienmckennaPorted to 6.x-5.x.
Comment #13
damienmckennaI've committed this to 6.x-5.x and 7.x-5.x.
Comment #14
damienmckennaI'm removing it from the lineup for 7.x-6.0-rc1 as I need to re-think the settings form.
Comment #15
damienmckennaI'm moving it to the goals list for 7.x-6.1.
Comment #16
damienmckennaComment #17
damienmckennaBecause of the different architecture between 7.x-5.x and 7.x-6.x, I'm moving this goal into a separate issue for 7.x-6.x (#2461937: Twitter Post support for revisioning and unpublished nodes) and closing this one.