In configuration area on drupal 7.7; on the "tweet button node settings" page - I only selected "blog entry" for the tweet button to appear.

It's appearing on my "services" page and my "about" page (both of which are "Basic pages"):
http://www.tmc13.com/services
http://www.tmc13.com/about

In fact, I tried every other option including unchecking every box - and the tweet button still shows on every page. The "weighting" option does work, but the selection boxes based on nodes do not work.

CommentFileSizeAuthor
#3 show_button_in_node_types_disticnt_of_config-1272424-3.patch887 byteswolmi

Comments

aliceduck’s picture

aliceduck commented

I'm also having this problem. In addition, the button also shows up in teasers when only checked to show up in full view.

blood2k’s picture

blood2k commented

I have the same problem.

wolmi’s picture

wolmi commented
Version: 7.x-1.x-dev » 7.x-1.1
StatusFileSize
new show_button_in_node_types_disticnt_of_config-1272424-3.patch887 bytes

I think this is the solution,

in tweetbutton.module in line 84 the if contition was wrong, must be this:

if(isset($type[$node->type]) && $type[$node->type] !== 0
    && in_array($view_mode, variable_get('tweetbutton_node_location', array('full')))
    && user_access('access tweetbutton')) {

Attached the patch.

I test it in stable version 7.x-1.1, I think is the same problem in dev.

offerman’s picture

offerman commented

This patch no longer needed after repairing this problem: "Currently displayed on teaser and node regardless of settings", replacing the entire function 'tweetbutton_node_view':
http://drupal.org/node/1139470

wolmi’s picture

wolmi commented

Thank for the info, I'll try to resolve this

achekulaev’s picture

achekulaev commented

Thanks @offerman that total function replacement fixes the issue.

offerman’s picture

offerman commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.