Closed (fixed)
Project:
TeamSpeak 3
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Jan 2012 at 23:15 UTC
Updated:
20 Jan 2012 at 00:16 UTC
kotake% drush review minor coder_tough_love ts3 Severity minor, Coder Tough Love sites/all/modules/ts3/ts3.module: +20: [normal] If you define a @param or @return, you should document it as well. +24: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +31: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +38: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +45: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +51: [normal] Administrative menu items should have a description. +76: [normal] If you define a @param or @return, you should document it as well. +76: [normal] @param and @return descriptions begin indented on the next line. +77: [normal] If you define a @param or @return, you should document it as well. +78: [normal] If you define a @param or @return, you should document it as well. +78: [normal] @param and @return descriptions begin indented on the next line. +115: [normal] If you define a @param or @return, you should document it as well. +116: [normal] If you define a @param or @return, you should document it as well. +134: [normal] If you define a @param or @return, you should document it as well. +134: [normal] @param and @return descriptions begin indented on the next line. +135: [normal] If you define a @param or @return, you should document it as well. +136: [normal] If you define a @param or @return, you should document it as well. +136: [normal] @param and @return descriptions begin indented on the next line. +147: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +169: [normal] If you define a @param or @return, you should document it as well. +170: [normal] If you define a @param or @return, you should document it as well. +187: [normal] If you define a @param or @return, you should document it as well. +222: [normal] Separate comments from comment syntax by a space. +237: [normal] Function summaries should be one line only. +238: [normal] If you define a @param or @return, you should document it as well. +239: [normal] If you define a @param or @return, you should document it as well. +239: [normal] @param and @return descriptions begin indented on the next line. +243: [normal] Separate comments from comment syntax by a space. +250: [normal] Separate comments from comment syntax by a space. +260: [normal] If you define a @param or @return, you should document it as well. +286: [normal] Use the matching Drupal theme functions, not raw HTML. +297: [normal] Separate comments from comment syntax by a space. +307: [normal] If you define a @param or @return, you should document it as well. +307: [normal] @param and @return descriptions begin indented on the next line. +308: [normal] If you define a @param or @return, you should document it as well. +308: [normal] @param and @return descriptions begin indented on the next line. +309: [normal] If you define a @param or @return, you should document it as well. +342: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +395: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +402: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +420: [normal] Function summaries should be one line only. +422: [normal] If you define a @param or @return, you should document it as well. +423: [normal] If you define a @param or @return, you should document it as well. +449: [normal] If you define a @param or @return, you should document it as well. +450: [normal] If you define a @param or @return, you should document it as well. +451: [normal] If you define a @param or @return, you should document it as well. +452: [normal] If you define a @param or @return, you should document it as well. +453: [normal] If you define a @param or @return, you should document it as well. +454: [normal] If you define a @param or @return, you should document it as well. +455: [normal] If you define a @param or @return, you should document it as well. +456: [normal] If you define a @param or @return, you should document it as well. +457: [normal] If you define a @param or @return, you should document it as well. +458: [normal] If you define a @param or @return, you should document it as well. +459: [normal] If you define a @param or @return, you should document it as well. +459: [normal] @param and @return descriptions begin indented on the next line. +470: [normal] Use the matching Drupal theme functions, not raw HTML. +473: [normal] Use the matching Drupal theme functions, not raw HTML. +475: [normal] Use the matching Drupal theme functions, not raw HTML. +475: [normal] Use the matching Drupal theme functions, not raw HTML. +501: [normal] Use the matching Drupal theme functions, not raw HTML. +506: [normal] Use the matching Drupal theme functions, not raw HTML. +509: [normal] Use the matching Drupal theme functions, not raw HTML. +536: [normal] If you define a @param or @return, you should document it as well. +552: [normal] If you define a @param or @return, you should document it as well. +573: [normal] If you define a @param or @return, you should document it as well. +573: [normal] @param and @return descriptions begin indented on the next line. +574: [normal] If you define a @param or @return, you should document it as well. +574: [normal] @param and @return descriptions begin indented on the next line. +608: [normal] If you define a @param or @return, you should document it as well. +608: [normal] Function documentation should be less than 80 characters per line. +608: [normal] @param and @return descriptions begin indented on the next line. +609: [normal] If you define a @param or @return, you should document it as well. +618: [normal] Function summaries should be one line only. +619: [normal] If you define a @param or @return, you should document it as well. +620: [normal] If you define a @param or @return, you should document it as well. +634: [normal] If you define a @param or @return, you should document it as well. +634: [normal] @param and @return descriptions begin indented on the next line. +635: [normal] If you define a @param or @return, you should document it as well. +635: [normal] @param and @return descriptions begin indented on the next line. +636: [normal] If you define a @param or @return, you should document it as well. +636: [normal] @param and @return descriptions begin indented on the next line. +653: [normal] If you define a @param or @return, you should document it as well. +653: [normal] @param and @return descriptions begin indented on the next line. +654: [normal] If you define a @param or @return, you should document it as well. +654: [normal] @param and @return descriptions begin indented on the next line. +655: [normal] If you define a @param or @return, you should document it as well. +655: [normal] @param and @return descriptions begin indented on the next line. +672: [normal] If you define a @param or @return, you should document it as well. +672: [normal] @param and @return descriptions begin indented on the next line. +673: [normal] If you define a @param or @return, you should document it as well. +673: [normal] @param and @return descriptions begin indented on the next line. sites/all/modules/ts3/includes/ts3_func.inc: +13: [normal] Separate comments from comment syntax by a space. +14: [normal] Separate comments from comment syntax by a space. +15: [normal] Separate comments from comment syntax by a space. +16: [normal] Separate comments from comment syntax by a space. +17: [normal] Separate comments from comment syntax by a space. +27: [normal] @param and @return descriptions begin indented on the next line. +28: [normal] @param and @return descriptions begin indented on the next line. +29: [normal] @param and @return descriptions begin indented on the next line. +30: [normal] @param and @return descriptions begin indented on the next line. +31: [normal] @param and @return descriptions begin indented on the next line. +46: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +50: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +57: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +67: [normal] Use sentence case, not title case, for end-user strings. (Wikipedia) +103: [normal] Use PHP's master function, not an alias. (List of PHP aliases) +112: [normal] @param and @return descriptions begin indented on the next line. +113: [normal] @param and @return descriptions begin indented on the next line. +114: [normal] @param and @return descriptions begin indented on the next line. +118: [normal] Use PHP's master function, not an alias. (List of PHP aliases) +132: [normal] @param and @return descriptions begin indented on the next line. +133: [normal] @param and @return descriptions begin indented on the next line. +150: [normal] @param and @return descriptions begin indented on the next line. +151: [normal] @param and @return descriptions begin indented on the next line. +161: [normal] @param and @return descriptions begin indented on the next line. +177: [normal] @param and @return descriptions begin indented on the next line. +188: [normal] Use Drupal's format_date(), not PHP's default date(). sites/all/modules/ts3/ts3.install: +8: [normal] Function summaries should be one line only. +9: [normal] If you define a @param or @return, you should document it as well. +102: [normal] If you define a @param or @return, you should document it as well. +102: [normal] @param and @return descriptions begin indented on the next line. +107: [normal] Separate comments from comment syntax by a space. +108: [normal] Separate comments from comment syntax by a space. +114: [normal] If you define a @param or @return, you should document it as well. +114: [normal] @param and @return descriptions begin indented on the next line. Status Messages: Coder found 1 projects, 3 files, 125 normal warnings, 0 warnings were flagged to be ignored
Comments
Comment #1
Freso commentedIn leaving ts3_func.inc for now, I've got the error report down to this:
The "Use the matching Drupal theme functions, not raw HTML." errors will be dealt with when #1395726: Use theme functions instead of hard coded HTML lands.
Changes committed.