Needs review
Project:
Translation 404 - Translation Page Not Found
Version:
6.x-1.2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2011 at 09:53 UTC
Updated:
7 Oct 2011 at 17:43 UTC
Jump to comment: Most recent file
Comments
Comment #1
bibo commentedI changed the title a bit. This isn't really about pressflow compatibility, since Pressflow can be used normally whether this module is enabled or not. However, pressflow allows unauthenticated users to not have sessions autogenerated (but only if they are needed).
The current behaviour of this module can be a serious performance killer, since it generates sessions for any traffic, including search crawlers etc. At worst, each pageload could generate a new crawler session (since the crawlers don't necessarily include cookies in their requests). This could mean that there are 70 000 sessions in the sessions table, even though only about 500 of them are actually used or make sense. I witnessed this on a well-sized site that had become really slow.
This SESSION-usage isn't really even needed. Luckily it's pretty easy to make this use sessions only for authenticated users, and avoid potentially over 90% of useless sessions.
Here is a simple patch attached, only a few lines changed + some comments. The most important lines are these:
Instead of:
PS: Since this module doesn't look very well maintained, I doubt It'll make it to the official release. So, probably you need to patch this manually.