Problem/Motivation

Current build on Gitlab CI for the 3.x branch passes with warnings due to phpunit next minor (11.5.x, 11.x) job failing with deprecation error messages, see:
https://git.drupalcode.org/project/toolbar_menu/-/pipelines/991499
PHPUNIT Next minor: https://git.drupalcode.org/project/toolbar_menu/-/jobs/12689329

Steps to reproduce

Run build pipeline for branch 3.x at:
https://git.drupalcode.org/project/toolbar_menu/-/pipelines

Proposed resolution

Force the deprecation error messages to be ignored:

  • Add PHP Attribute IgnoreDeprecations in the only test file:
    tests/src/Functional/ToolbarMenuFunctionalTest.php
  • In Gitlab CI file, add override for phpstan (previous major) to remove the IgnoreDeprecations PHP Attribute in before_script to prevent prompting errors.

 

Issue fork toolbar_menu-3628874

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dydave created an issue. See original summary.

dydave opened merge request !11

  • dydave committed 2a438a86 on 3.x 
    Issue #3628874 by dydave: Gitlab CI: Fixed phpunit next minor (11.x) by...
dydave’s picture

dydave commented
Status: Active » Fixed

Quick follow-up on this ticket:
All the changes described in the issue summary were implemented in merge request MR !11, created above at #2.

✅ 0 functional code file impacted == 0 change in module files.
✅ 100% of the changes are in tests and Gitlab CI config.

Since all the jobs and tests were still passing 🟢, I went ahead and merged the changes above at #3.🥳

The build pipelines are all coming back green 🟢 now, see:
https://git.drupalcode.org/project/toolbar_menu/-/pipelines/991573

Which was the object of this issue.

Since all the work to be carried in this issue should have been completed at this point, marking as Fixed for now.

Thanks in advance!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.