Problem/Motivation

Originally found in #3331424: Drop -moz- vendor prefixed properties and then discussed in Slack with @alexpott, @mherchel and @andy-blum.

In toolbar's CSS we have the following non-standard properties:

  -moz-tap-highlight-color: rgba(0, 0, 0, 0);
  -o-tap-highlight-color: rgba(0, 0, 0, 0);
  -webkit-tap-highlight-color: rgba(0, 0, 0, 0);
  tap-highlight-color: rgba(0, 0, 0, 0);
  -moz-touch-callout: none;
  -o-touch-callout: none;
  -webkit-touch-callout: none;
  touch-callout: none;

These were originally introduced in an early prototype of the toolbar CSS in #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop

These properties are currently only supported by Safari on iOS, with the -webkit- vendor prefix, and even then we are not sure that they do anything useful.

https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout
https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-tap-highlight-c...

Steps to reproduce

Proposed resolution

Remove these properties.
Check for regressions on iOS.
If the properties are useful:

  • Keep only the -webkit- prefixed versions.
  • Add a comment explaining what the properties do.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

longwave created an issue. See original summary.

andy-blum’s picture

Note that these toolbar styles are also in Claro: https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/themes/clar...

longwave’s picture

Issue summary: View changes

longwave credited alexpott.

longwave credited mherchel.

longwave credited Spokje.

longwave’s picture

Adding issue credits for discussion and also @Spokje who created duplicates of this issue at the same time.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Status: Active » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.

quietone’s picture

Project: Drupal core » Toolbar
Version: main » 1.x-dev
Component: toolbar.module » Code
Status: Postponed » Active

Toolbar has moved to contrib