Problem/Motivation
Following #3321006: Drop -ms- vendor prefixed CSS properties we still have a number of vendor-prefixed properties that are probably safe to remove.
Per @alexpott:
I think we should move the tap-highlight-color and touch-callout to there own issue. I think touch-callout is simple - we should only have the webkit prefixed one - because this only works on iOS. tap-highlight-color is trickier because it works in quite a few places.
Steps to reproduce
Proposed resolution
Search for -moz-
Determine which properties can be safely removed
Remove them
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | interdiff.3-13.txt | 2.28 KB | spokje |
| #13 | 3331424-13.patch | 11.21 KB | spokje |
Comments
Comment #2
longwaveThe following properties are present in core:
Therefore I think we can remove most -moz- prefixed properties, with the exception of -moz-user-modify, the ones in the XSS test cases, and the ones in core/tests/Drupal/Tests/Core/Asset/css_test_files which are useful test cases for vendor prefixes.
Comment #3
longwaveComment #4
spokjePatch looks good to me, the only thing I don't understand is why we want to keep the obsolete
-moz-user-modifyaround.Does that one come upstream from CKEditor5?
Comment #5
mukhtarm commentedunfortunately this patch is not applying for me, tried with composer and git. please see the screenshot
Comment #6
longwave@Spokje sorry I should have explained my reasoning for that more: https://bugzilla.mozilla.org/show_bug.cgi?id=1388910 says "It seems like the only thing we do with the property is, under some conditions, change whether the caret is visible [...] If we remove it, we might need something else to control the caret behavior" and I assumed that because CKEditor5 uses it, it is still a valid use of it. However I'm not sure that is actually the case, I guess this needs manual testing.
@MukhtarM I am not sure what has happened in your screenshots but the patch still applies cleanly to 10.1.x for me.
Comment #7
spokjeThanks for explaining @longwave.
Do we want to look at the usage of
-moz-user-modifyin this issue, in a follow-up, or do we leave that for another time?'In case we want to do it here: Should we contact CKEditor5-boffins like WimLeers, lauriii or bnjmnm?
Comment #8
longwaveGiven that the only use of
user-modifyis a single line in ckeditor5.js, I think we should open a separate issue to deal with that (and the -webkit- version at the same time) and let CKEditor5 maintainers make the decision.Comment #9
spokjeThanks @longwave, all clear and RTBC for me.
Comment #10
alexpottI think we should move the tap-highlight-color and touch-callout to there own issue. I think touch-callout is simple - we should only have the webkit prefixed one - because this only works on iOS. tap-highlight-color is trickier because it works in quite a few places.
Please re-rtbc once these changes have been removed and a separate issue exists.
Comment #11
spokjeI went a little overboard and created 2 issues, since we're probably can get the touch-callout in way before the tap-highlight-color one.
#3332022: Keep only webkit-touch-callout property and #3332027: Drop tap-highlight-color properties where appropriate
Comment #12
spokjeComment #13
spokjeReverted removal of
-moz-tap-highlight-colorand-moz-touch-calloutand reRTBCedComment #14
alexpottCommitted 8df8357 and pushed to 10.1.x. Thanks!