Problem/Motivation

Following #3321006: Drop -ms- vendor prefixed CSS properties we still have a number of vendor-prefixed properties that are probably safe to remove.

Per @alexpott:

I think we should move the tap-highlight-color and touch-callout to there own issue. I think touch-callout is simple - we should only have the webkit prefixed one - because this only works on iOS. tap-highlight-color is trickier because it works in quite a few places.

Steps to reproduce

Proposed resolution

Search for -moz-
Determine which properties can be safely removed
Remove them

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

longwave created an issue. See original summary.

longwave’s picture

The following properties are present in core:

-moz-animation not required since Firefox 16
-moz-animation-direction not required since Firefox 16
-moz-appearance not required since Firefox 80
-moz-binding obsolete since Firefox 67
-moz-hyphens not required since Firefox 43
-moz-selection not required since Firefox 62
-moz-tap-highlight-color does not appear to be valid?
-moz-touch-callout does not appear to be valid?
-moz-transition not required since Firefox 16
-moz-transition-property not required since Frefox 16
-moz-user-modify obsolete, scheduled to be removed from Firefox in the future

Therefore I think we can remove most -moz- prefixed properties, with the exception of -moz-user-modify, the ones in the XSS test cases, and the ones in core/tests/Drupal/Tests/Core/Asset/css_test_files which are useful test cases for vendor prefixes.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new14.03 KB
spokje’s picture

Patch looks good to me, the only thing I don't understand is why we want to keep the obsolete -moz-user-modify around.
Does that one come upstream from CKEditor5?

mukhtarm’s picture

unfortunately this patch is not applying for me, tried with composer and git. please see the screenshot

longwave’s picture

Status: Needs review » Needs work

@Spokje sorry I should have explained my reasoning for that more: https://bugzilla.mozilla.org/show_bug.cgi?id=1388910 says "It seems like the only thing we do with the property is, under some conditions, change whether the caret is visible [...] If we remove it, we might need something else to control the caret behavior" and I assumed that because CKEditor5 uses it, it is still a valid use of it. However I'm not sure that is actually the case, I guess this needs manual testing.

@MukhtarM I am not sure what has happened in your screenshots but the patch still applies cleanly to 10.1.x for me.

spokje’s picture

Thanks for explaining @longwave.

Do we want to look at the usage of -moz-user-modify in this issue, in a follow-up, or do we leave that for another time?'
In case we want to do it here: Should we contact CKEditor5-boffins like WimLeers, lauriii or bnjmnm?

longwave’s picture

Status: Needs work » Needs review

Given that the only use of user-modify is a single line in ckeditor5.js, I think we should open a separate issue to deal with that (and the -webkit- version at the same time) and let CKEditor5 maintainers make the decision.

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @longwave, all clear and RTBC for me.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

I think we should move the tap-highlight-color and touch-callout to there own issue. I think touch-callout is simple - we should only have the webkit prefixed one - because this only works on iOS. tap-highlight-color is trickier because it works in quite a few places.

Please re-rtbc once these changes have been removed and a separate issue exists.

spokje’s picture

I went a little overboard and created 2 issues, since we're probably can get the touch-callout in way before the tap-highlight-color one.

#3332022: Keep only webkit-touch-callout property and #3332027: Drop tap-highlight-color properties where appropriate

spokje’s picture

Issue summary: View changes
spokje’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new11.21 KB
new2.28 KB

Reverted removal of -moz-tap-highlight-color and -moz-touch-callout and reRTBCed

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 8df8357 and pushed to 10.1.x. Thanks!

  • alexpott committed 8df8357c on 10.1.x
    Issue #3331424 by Spokje, longwave: Drop -moz- vendor prefixed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.