Problem/Motivation

We have a number of -ms- prefixed CSS properties:

-ms-animation
-ms-backface-visibility
-ms-check
-ms-clear
-ms-expand
-ms-fullscreen
-ms-grid-row
-ms-grid-row-align
-ms-hyphens
-ms-ime-align
-ms-keyframes
-ms-linear-gradient
-ms-touch-action
-ms-transform
-ms-transition
-ms-transition-property
-ms-user-select

We no longer support IE11 so we should be able to drop many if not all of these.

Steps to reproduce

Proposed resolution

Remaining tasks

Decide whether to do the same for -webkit- and -moz- properties.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3321006-9.patch21.6 KBlongwave
#5 interdiff_3-4.txt436 bytesnivethasubramaniyan
#5 3321006-4.patch16.21 KBnivethasubramaniyan
#3 3321006-3.patch16.28 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3321006-3.patch16.28 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
nivethasubramaniyan’s picture

nivethasubramaniyan commented
StatusFileSize
new 3321006-4.patch16.21 KB
new interdiff_3-4.txt436 bytes

Fixing CCF

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Thanks.

+++ b/core/themes/olivero/css/components/header-search-wide.pcss.css
@@ -151,16 +138,6 @@
       /* Edge's high contrast does show the background image, so we hide it. */

Not sure if we can remove this as well?

andypost’s picture

andypost
he/him
Primary language Russian
commented

There's' a bunch of them could be greped in core/.stylelintrc.json

smustgrave’s picture

smustgrave commented
Version: 10.0.x-dev » 10.1.x-dev
Status: Needs review » Needs work

Think this missed the 10.0 window

Patch #5 does not apply to 10.1

Is there additional work for #6 or #7?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 3321006-9.patch21.6 KB

Rerolled and addressed #7.

#6 is still an open question but we could handle testing all the remaining -ms-high-contrast rules in a followup?

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Opened up #3327405: Convert -ms-high-contrast to forced-colors for a follow up

Good to mark this one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I've checked out the css properties on https://caniuse.com/ and edge supports the unprefixed version on all the removed -ms- properties.

We definitely should do the same for -moz- and -webkit- - we could also update the stylelintrc rule to prevent us adding them by accident in the future... https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

Committed 2d12ec2 and pushed to 10.1.x. Thanks!

  • alexpott committed 2d12ec23 on 10.1.x 
    Issue #3321006 by longwave, NivethaSubramaniyan: Drop -ms- vendor...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.