Problem/Motivation

The admin config items of tmgmt are missing a description.
That looks strange with the other items.

Proposed resolution

Add a description to make it appear similar to the other items.

Remaining tasks

User interface changes

Without selection, a cart action applies to all cart items.

CommentFileSizeAuthor
#14 Screenshot from 2016-02-08 12:17:37.png9.02 KBjohnchque
#14 Screenshot from 2016-02-08 11:53:11.png33.77 KBjohnchque
#14 interdiff-2655578-12-14.txt2.85 KBjohnchque
#14 add_description_to-2655578-14.patch13.95 KBjohnchque
#12 interdiff-2655578-9-12.txt9.99 KBjohnchque
#12 add_description_to-2655578-12.patch11.26 KBjohnchque
#12 Screenshot from 2016-02-08 11:53:11.png33.77 KBjohnchque
#9 Screenshot from 2016-02-08 10:21:45.png30.68 KBjohnchque
#9 interdiff-2655578-6-9.txt1.9 KBjohnchque
#9 add_description_to-2655578-9.patch1.98 KBjohnchque
#6 Screenshot from 2016-02-04 17:11:37.png19.85 KBjohnchque
#6 add_description_to-2655578-6.patch631 bytesjohnchque
Screen Shot 2016-01-23 at 23.10.42 .png37.85 KBmiro_dietiker

Comments

miro_dietiker created an issue. See original summary.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Hm, or should we even merge translators and settings and thus only have one TMGMT item in config?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It does, but adding a description just so it doesn't look strange is also a bit strange. What I find a lot weirder is that they're very long.

What about something completely different? Move those also to /admin/tmgmt as local task. We initially decided against that, but since we have that... commerce also has its settings there. Allows us to shorten it to just Settings and Translators.

slashrsm’s picture

slashrsm commented

Should we proceed with #3?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Now that we have /admin/tmgmt too as an overview page, I think we'll need descriptions anyway. So we can just add those for now and then think about moving it.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
StatusFileSize
new add_description_to-2655578-6.patch631 bytes
new Screenshot from 2016-02-04 17:11:37.png19.85 KB

Added description and screenshot. Looks nice now.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

Yeah i think we should also move it to the translate area then and cover everything there.
I think i would add them at the end in this sequence:
- Translators (Would be renamed later to "Providers" in #2662498: Rename Translator to Provider)
- Settings

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new add_description_to-2655578-9.patch1.98 KB
new interdiff-2655578-6-9.txt1.9 KB
new Screenshot from 2016-02-08 10:21:45.png30.68 KB

Changes made based on comment #8, now it looks even better. Tests fixed and added screenshot.

Status: Needs review » Needs work

The last submitted patch, 9: add_description_to-2655578-9.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Not sure if we should do changes to existing descriptions here but I guess why not, we need to review them all together anyway. There are some typos and some are too technical/short.

Please also post a description where the local tasks are visible too. I think we should add local tasks for translator and settings as well now, and possibly change the path if you didn't already so that the default breadcrumb makes sense.

* Overview of jobs doesn't really tell me much. Maybe "Manage and review existing translation jobs."
* off typo in sources. also too technical, we should not talk about plugins in the UI. Maybe "View translation status of your site and create new jobs." ?
* There is only one cart (per user). Maybe we can explain a bit more what you can do there, not sure how.
* Wondering if we can somehow find a description that makes the distinction between translators and translate clearer. Maybe use the term "job translator" for translators in the description? And for local translate, instead of "local", which we AFAIK usually avoid in the UI, we could use task translations?

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2016-02-08 11:53:11.png33.77 KB
new add_description_to-2655578-12.patch11.26 KB
new interdiff-2655578-9-12.txt9.99 KB

Changes made, fixed tests and paths on settings and translators.

Status: Needs review » Needs work

The last submitted patch, 12: add_description_to-2655578-12.patch, failed testing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new add_description_to-2655578-14.patch13.95 KB
new interdiff-2655578-12-14.txt2.85 KB
new Screenshot from 2016-02-08 11:53:11.png33.77 KB
new Screenshot from 2016-02-08 12:17:37.png9.02 KB

Added tabs:

Description added.

Fixed tests. Should work now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Assigned: Unassigned » miro_dietiker

Was confused a bit, note that those are two different screenshots. And the overview page currently doesn't show local tasks.

I'm not sure what's better.. having an overview local task and also showing them there vs. then possibly confusing users with two options to navigate.

links and descriptions make sense to me now, a lot better than before. Lets give miro a chance to review this.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Looks pretty good to me. But it seems i don't fully get what the alternative option(s) would be.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committted.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.