TMGMTFileformatXLIFF->getImportedXML fails with a fatal error if the file doesn't contain a valid XML.

CommentFileSizeAuthor
#5 tmgmt-getImportedXML-fails-fatal-error-2393393-4.patch1.72 KBdragos-dumi
#1 tmgmt-fatal-error-on-import-2393393-1.patch1.8 KBmfernea

Comments

mfernea’s picture

mfernea commented
StatusFileSize
new tmgmt-fatal-error-on-import-2393393-1.patch1.8 KB

Here is the patch.

mfernea’s picture

mfernea commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Looks like it might still display some warnings/notices, but that's not as bad as a fatal error :)

Thanks, committed.

  • Berdir committed c4661fa on 7.x-1.x authored by mfernea 
    Issue #2393393 by mfernea: getImportedXML fails with a fatal error if...
dragos-dumi’s picture

dragos-dumi commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new tmgmt-getImportedXML-fails-fatal-error-2393393-4.patch1.72 KB

Attached the ported patch for 8.x-1.x branch

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks for the port, sorry for taking so long to get to this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.