I'm currently tracking time on a node bundle's comments. However, some users will not enter time. I'd like to be able to not require entering time when entering a comment. I assumed that by checking the boxes under Global Settings/Fieldset Settings, this would hide the time tracking area and also not require. It seems to do neither, as the fields are still there, not collapsed. Any suggestions on what I'm doing wrong?

CommentFileSizeAuthor
#5 time_tracker-time-do-not-require-entry-1937568-5.patch1.54 KBbwoods

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Fixed

I've implemented some new handling of the time tracker form and content to better respect permissions. For your case, just dont give the people that wont be adding time entries the "add time tracker entries" permission.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bwoods’s picture

bwoods commented

Thanks for doing this, I will try it out.

I think it's also possible that people entering time on comments may not need to enter time for each comment. For instance, if two developers are working on a project, and one just wants to comment to assign to someone else (in my case, I'm using the support module), this wouldn't need time associated with it.

I currently have a small hack at the top of time_tracker_comment_insert to check for $comment->duration, and if empty, just return. In your entity settings, you could theoretically have a checkbox to require time, but this might be such an edge case that it's best to keep out of your module altogether (since the objective is to track time, so why would you NOT want to track time, right?).

bwoods’s picture

bwoods commented
Issue summary: View changes

(omitted)

bwoods’s picture

bwoods commented
StatusFileSize
new time_tracker-time-do-not-require-entry-1937568-5.patch1.54 KB

I've gone ahead and created a patch for this - while it may not be accepted, I figured others may find it useful if they have the same edge case as me. Thanks!