themesettings.admin.inc just contains the implementation of hook_form_alter(), which is conditionally executed.
The code for the hook should be put directly in themesettings.module.

CommentFileSizeAuthor
themesettingsapi_module.patch6.56 KBavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Conditionally include of themesettings.admin.inc is not necessary » Remove themesettings.admin.inc
johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Closed (duplicate)

This is a duplicate of the issue you just submitted 30 minutes earlier. #263384: Conditional including of themesettings.admin.inc is not necessary What gives?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Closed (duplicate) » Needs review

I am sorry.
It seems I have an issue with drupal.org: sometimes, when I submit an issue, I don't see it anymore. I mean that I don't see it in "My issues", nor I see it in the issues of the project.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Closed (duplicate)

ok. but this is still a duplicate issue. See #263384: Conditional including of themesettings.admin.inc is not necessary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

My apologies.
I didn't notice Drupal filters the issues showing by default only the active ones. As I was not able to see my old issue, this issue didn't appear as a duplicate, to me.