themesettings.admin.inc simply contains the implementation of hook_form_alter(), which already has conditionally executed code (it works just on the theme settings form).

The hook_form_alter() should be in the module file, and the code to include themesettings.admin.inc should be removed at all.

CommentFileSizeAuthor
themesettingsapi_module.patch6.56 KBavpaderno

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Closed (works as designed)

By conditionally including the themesettings.admin.inc file, the amount of code that needs to be parsed on every page load has been reduced.