Rather than figuring out how to hook and form alter https://www.drupal.org/sandbox/coltrane/2200763 into TFA Basic it'd be easier and simpler to add the plugin in to this project.

CommentFileSizeAuthor
#3 2324159-tfa-basic-sms.patch44.45 KBcoltrane

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Makes sense to me.

monstrfolk’s picture

monstrfolk commented

I agree

coltrane’s picture

coltrane
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2324159-tfa-basic-sms.patch44.45 KB

Patch adds Twilio SMS plugin with support for account fields for storing the mobile number to use. See README.txt in patch for how to use different number storage with alter hooks.

Also fixed form logic if any plugins aren't enabled.

dpintats’s picture

dpintats commented

Tested in a bare D7 install with tfa and tfa_basic modules installed and set up with a Twilio Developer account. Module works as expected, when setting the Twilio number explicitly in the settings.php $conf array.

There was an error in the user's phone number displaying from tfa_basic_format_number, but this is already resolved in patches from https://www.drupal.org/node/2325409.

  • coltrane committed 335c46c on 7.x-1.x 
    iIssue #2324159: Added optional SMS plugin using Twilio.
coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Fixed

Thanks @dpintats! I've committed this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.