PHP 7.3 has introduced a change in how continue can be used in a switch, and now tests are failing. See https://www.drupal.org/node/52349/qa

CommentFileSizeAuthor
#17 3014590-17.patch16.11 KBmondrake
#15 3014590-15.patch16.1 KBmondrake
#13 3014590-14.patch16.06 KBmondrake
#11 3014590-12.patch15.84 KBmondrake
#9 3014590-10.patch8.47 KBmondrake
#8 3014590-8.patch7.75 KBmondrake
#6 3014590-6.patch7.64 KBmondrake
#4 3014590-4.patch4.7 KBmondrake
#2 3014590-2.patch2.26 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Support PHP 7.3 » Convert tests to B2B and support PHP 7.3
Status: Active » Needs review
StatusFileSize
new 3014590-2.patch2.26 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3014590-2.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-4.patch4.7 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3014590-4.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-6.patch7.64 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3014590-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 3014590-8.patch7.75 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-10.patch8.47 KB

Status: Needs review » Needs work

The last submitted patch, 9: 3014590-10.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-12.patch15.84 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3014590-12.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-14.patch16.06 KB

Status: Needs review » Needs work

The last submitted patch, 13: 3014590-14.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-15.patch16.1 KB

Status: Needs review » Needs work

The last submitted patch, 15: 3014590-15.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3014590-17.patch16.11 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Title: Convert tests to B2B and support PHP 7.3 » Convert tests to PHPUnit

This is (just) converting the tests to PHPUnit. The PHP 7.3 compatibility seems more related to the Image Effects module for which there is not yet a point release supporting PHP 7.3.

  • mondrake committed d44513e on 8.x-3.x 
    Issue #3014590 by mondrake: Convert tests to PHPUnit
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.