Proposal to contribute to Textimage 7.x-2.x

Hi wundo,

thanks for coming back.

You may want to take a look at the sequence of commits and diffs on my sandbox project at http://drupalcode.org/sandbox/mondrake/1647516.git/shortlog/refs/heads/7... , you will see the steps that led to the patch I eventually posted.

if your question is about breaking the patch itself into patches addressing each one of the issues, then honestly I would not know how to do it now... The way I did it was to clone the official project git in my sandbox and then posting commits till I got to the result I needed.

Anyway. To be quite frank I moved on. I have some ideas for additional features and to align better to Drupal 7:

• make use of the Image features that were embedded in core Drupal 7 (image effects/styles)
• create a 'text_overlay' effect to be used in Image styles (i.e. start from an image insetad of starting from the preset)
• review of caching functions (again, aligned to Image core features)
• backgrounds to be part of an administration form, with upload/delete capabilities
• direct text to image theme (i.e. without having to use presets)
• review image and preset settings structure
• use OOP where possible
• @font-your-face module integration for font management
• use of wrappers for image storage

So in my sandbox I started working on a 7.x-3.x branch. I do not know how long will it take (this is taking my free time), and whether I'll end up with a new release of Textimage or rather with an entirely new module. You can check my progress there if you want. In any case, I'll touch base with you when I will have something that can be made public, ok?

cheers
mondrake

Makes sense. As to the hook_init, I introduced it as I prefer to see code being part of specifc function rather than 'loose', outside of any function. But I agree, can do without.

Thanks wundo. :-)

Agree. Does it mean that I can push commits to the repo now?
Currently I don't have time, but let's say by the end if the month I should be able to have an environment up with 7.x-2.x dev and push the commits for the two remaining. Ok with that?

Closing this issue then.

mondrake

Hi wundo,

I just pushed a commit to fix #1273760: Can't create images through url. in 7.x-2.x; I have not edited the issue in the issue queue yet, that should be done I guess after a new release?

For #1378018: text image no works in cck, that was to me a duplicate of #1421292: Cannot get textimage to work in D7 - no presets selectable in View or display fields, which you fixed in alpha2 already, so I marked it fixed in the issue queue.

Note: the 7.x-2.x-dev release is not marked for snapshot build so the dev package is currently outdated by the alpha2 release.

Looking forward to your comments

OK done