I'm using pgSQL as my database and have upgraded to 5.1 today. During the upgrade I got an error in the SQL script that performs the database changes. I don't have the exact error message, but the problem was related to the 'CREATE TABLE' statement. A field named 'presetid' was used in a couple of places. That field does not exist. I changed the code (see patch below), which resolved the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | textimage-5.x-1.2.patch | 4.36 KB | karora |
| #3 | textimage-5.x-1.2-pgsql_0.patch | 1.73 KB | jandd |
| #2 | textimage-5.x-1.2-pgsql.patch | 1.55 KB | jandd |
| textimage-5.patch | 590 bytes | pthomsen |
Comments
Comment #1
pthomsen commentedOops. Since I have a patch, I changed the status.
Comment #2
jandd commentedimproved patch that takes care of uninstall and update too
Comment #3
jandd commentedPatch updated to create and drop the correct sequence name. Tested with Drupal 5.1 and PostgreSQL 8.1, works like a charm after making the fonts directory writable for Apache (see http://drupal.org/node/111838)
Comment #4
ardas commentedYes, I have the same problems.
One thing, I propose to change pid column type to int_unsigned and remove superfluous NOT NULL (since the column is PK already).
Comment #5
karora commentedHere is a further patch, which fixes both problems. I can't see a reason not to commit this, since the bug is stopping people from using the module without complicated manual mucking around.
This patch differs from the previous ones in that it:
- moves the "PRIMARY KEY" into the field spec and removes the redundant "NOT NULL"
- replaces the checks of the fonts_dir & images_dir with is_dir(), since these directories do not need to be writable. (i.e. also fixes http://drupal.org/node/111838 )
Other than this it is the same as the previous patch.
I have tested this, and it seems to work.
Comment #6
decipheredPatch is out of date (no fault of patch contributors) and needs a re-write.
Patch should only contain fixes related to this issue, any other fixes should be posted to a separate issue.
As I don't know Postgres I do hope that someone will take the time to submit a working patch, and I will be certain to make sure it goes into the code.
Comment #7
decipheredFixed in DRUPAL-5--2.