I have submitted two patches for issue #1530148 in OG (http://drupal.org/node/1530148) and they have been tested by two individual bots (664 and 669) the test results are here..

http://qa.drupal.org/pifr/test/254169 and http://qa.drupal.org/pifr/test/254174

I have followed Drupal's patch creation standards etc and they keep failing. Is this repo down, am I doing something wrong, the branch wasn't created properly, or is it a testing bot bug?

Thank you

Comments

rfay’s picture

Title: FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/og.git]. » Duplicate module checkout for og

It looks like og is being downloaded twice.

From the "Review Log" section of http://qa.drupal.org/pifr/test/254174

[14:49:29] Command [git clone 'git://git.drupal.org/project/og.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/og' --reference /var/cache/git/reference 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Status [128]
 Output: [fatal: destination path '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/og' already exists and is not an empty directory.].
[14:49:29] Dependency branch [7.x-2.x] checkout [failed].
rfay’s picture

og is listed twice in the dependencies section. Once with the VCS Id 7.x-2.0-alpha1, and then with 7.x-2.x

If I were to guess, I would expect this to be a result of the deployment of #1507650: "Failed to check out": Internal dependencies not followed properly within a project (extra dependency) today.

tehbmar’s picture

So is there anything I can do to get my patch up or do we need to contact the OG maintainer?

rfay’s picture

The problem is that og 7.x-1.3 is listed as a dependency. I would say that's the problem, and I would blame it on #1507650: "Failed to check out": Internal dependencies not followed properly within a project (extra dependency). However, I always thought even PIFT did a check to make sure something wasn't listed twice.

drush pdsd og 7.x-2.x-dev
Array
(
    [1324936] => Array
        (
            [uri] => og
            [version] => 7.x-1.3
            [tag] => 7.x-1.3
        )

    [1337360] => Array
        (
            [uri] => entity
            [version] => 7.x-1.0-rc1
            [tag] => 7.x-1.0-rc1
        )

    [1430758] => Array
        (
            [uri] => views_bulk_operations
            [version] => 7.x-3.0-rc1
            [tag] => 7.x-3.0-rc1
        )

    [1451068] => Array
        (
            [uri] => views
            [version] => 7.x-3.3
            [tag] => 7.x-3.3
        )

    [1507412] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.0
            [tag] => 7.x-1.0
        )

    [1425592] => Array
        (
            [uri] => entityreference_prepopulate
            [version] => 7.x-1.x-dev
            [tag] => 7.x-1.x
        )

    [1438768] => Array
        (
            [uri] => entityreference
            [version] => 7.x-1.0-beta4
            [tag] => 7.x-1.0-beta4
        )

    [1393112] => Array
        (
            [uri] => features
            [version] => 7.x-1.0-beta6
            [tag] => 7.x-1.0-beta6
        )

    [1409448] => Array
        (
            [uri] => panels
            [version] => 7.x-3.0
            [tag] => 7.x-3.0
        )

)
longwave’s picture

Title: Duplicate module checkout for og » Duplicate module checkout

Ubercart is suffering from the same issue, checking out both 7.x-3.0 and 7.x-3.x.

http://qa.drupal.org/pifr/test/132134

[14:07:14] Command [git clone 'git://git.drupal.org/project/ubercart.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart' --reference /var/cache/git/reference 2>&1] succeeded.
[14:07:14] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart/.git' checkout '7.x-3.0' 2>&1] succeeded.
[14:07:14] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart/.git' status 2>&1] succeeded.
[14:07:14] Dependency branch [7.x-3.0] checkout [complete].
...
[14:07:38] Command [git clone 'git://git.drupal.org/project/ubercart.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart' --reference /var/cache/git/reference 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Status [128]
 Output: [fatal: destination path '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/ubercart' already exists and is not an empty directory.].
[14:07:38] Dependency branch [7.x-3.x] checkout [failed].
rfay’s picture

Status: Active » Closed (duplicate)

Yes, and sorry. It is in fact caused by a failure in #1507650: "Failed to check out": Internal dependencies not followed properly within a project (extra dependency), which was deployed today.

That one is marked critical, and marking this one as a duplicate

rfay’s picture

Status: Closed (duplicate) » Fixed

I just reverted the deploy of project_dependency 6.x-1.0-beta2, so this problem should be resolved. I'll go push the button for the ubercart and og issues.

rfay’s picture

It is possible that additional modules may be affected, and that they'll have to have their dependencies manually rebuilt. If that's the case, you can request it here.

rfay’s picture

Title: Duplicate module checkout » Duplicate module checkout (Repository checkout: failed to checkout from [git://git.drupal.org/...]
tim.plunkett’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.