hook help is missing as per drupal coding standards.

CommentFileSizeAuthor
#8 TB Mega Menu1.jpg91.71 KBNeetika K
#7 2982006-hook-help-5.patch1.77 KBbrahmjeet789
#6 TB Mega Menu.jpg103.21 KBNeetika K
#5 2982006-hook-help-3.patch1.74 KBbrahmjeet789
#4 after-patch.jpeg11.76 KBVidushi Mehta
#4 before-patch.jpeg7.73 KBVidushi Mehta
#2 2982006-hook-help-1.patch1.7 KBbrahmjeet789

Comments

brahmjeet789 created an issue. See original summary.

brahmjeet789’s picture

brahmjeet789 commented
StatusFileSize
new 2982006-hook-help-1.patch1.7 KB

i have added patch for the same ,please review it .

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Active » Needs review
Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before-patch.jpeg7.73 KB
new after-patch.jpeg11.76 KB

Reviewed #2 and it looks good. Added before after screenshots for the same.

brahmjeet789’s picture

brahmjeet789 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2982006-hook-help-3.patch1.74 KB

As per drupal standard i changed the help function ,please review .

Neetika K’s picture

Neetika K commented
StatusFileSize
new TB Mega Menu.jpg103.21 KB

brahmjeet789: Patch applied suucessfully.
The alignment is not proper under 'Uses'.Please see the highlighted part in the screenshot.

brahmjeet789’s picture

brahmjeet789 commented
StatusFileSize
new 2982006-hook-help-5.patch1.77 KB

@neetika: as per your comment i rerolled my patch and created new one ,please test.

Neetika K’s picture

Neetika K commented
StatusFileSize
new TB Mega Menu1.jpg91.71 KB

@brahmjeet789 : Patch is applied cleanely. Looks fine now

Neetika K’s picture

Neetika K commented
Status: Needs review » Reviewed & tested by the community
themodularlab’s picture

themodularlab
He/Him
Primary language English
commented

Patch re-reviewed due to amount of time since last review. Looks good. Will commit this. Thanks!

themodularlab’s picture

themodularlab
He/Him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.