Closed (fixed)
Project:
Taxonomy Manager
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2019 at 21:28 UTC
Updated:
17 Jan 2023 at 14:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
a.koch82 commentedWell patch is done. It need review. I added menu item for load term through drupal ahah. Also i used custom callback for ahah submit, but it was controversial decision. However please review this patch and give me your feedback. Thanks.
Comment #3
firehawkx commentedhummm getting the following message when trying to apply the patch...
(this is most likely due to the previous patch you made to remember the position)
warning: css/taxonomy_manager.css has type 100644, expected 100755
error: while searching for:
display: inline;
}
error: patch failed: css/taxonomy_manager.css:569
error: css/taxonomy_manager.css: patch does not apply
Checking patch js/termData.js...
Checking patch taxonomy_manager.admin.inc...
Hunk #4 succeeded at 1766 (offset 3 lines).
Hunk #5 succeeded at 1873 (offset 3 lines).
Checking patch taxonomy_manager.module...
warning: taxonomy_manager.module has type 100644, expected 100755
Hunk #2 succeeded at 1101 (offset 1 line).
here are the 2 patches i currently have installed :
-fix_reset_panel_for_different_version_jquery-2787505-5.patch
-remember_position_after_CRUD-855002-2.patch (this is the other patch that was made to remember the position and the one that conflict with this one)
I tried to apply manually AND on a clean dev, but got major bugs
(nothing would display at all, or only depth 0 could be clicked or it would crash)
Thank you very much for trying and for all your help!!
It is greatly appreciated! :)
Comment #4
a.koch82 commentedHello. I prepared next version of patch for this problem. In current version i used a more simple solution. I used step-by-step debug and i think than i found the problem.
However it needs test and review. Thanks.
Comment #5
firehawkx commentedIT WORKS! :)
Really fantastic job!
For anyone who wishes to use Taxonomy Manager along with Paragraphs this is an absolute MUST HAVE :)
Comment #7
vladimirausThank you for you work! 🍻
Committed!