For my theme, I had to do a lot of overriding of CSS from this module that forced specific dimensions (width, margin, padding, etc.) and floats. I'd like to put a little bit of effort into reducing the amount of CSS for this module. In some cases, I'd also like to remove some HTML structure that's not in a theme function or move it to a theme function.

I know that this module has unique features and functions, so it needs some special UI. My goal isn't to disrupt anything useful or even make substantial UI changes! I hope the maintainers and other users of this module consider patches here and add their own to this issue. Starting out, I'm focusing on patches that reduce the amount of CSS and reuse CSS rules from elsewhere in Drupal.

CommentFileSizeAuthor
#8 taxonomy-manager-theme.patch11.27 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

This patch re-uses the admin page layout CSS: div.admin, div.admin .left and div.admin .right. If your theme shows the admin page correctly, your theme should show the taxonomy manager admin page correctly.

Anonymous’s picture

Anonymous (not verified) commented

The stylesheet resets padding to 0 on elements that never had padding in the first place. It also changes padding on fieldsets and table cells, which have reasonable padding defined in system.css and the theme's style.css on a more generic basis.

Anonymous’s picture

Anonymous (not verified) commented

This patch makes the search form on the admin page look less customized and specific for this module. In the process, removed the special "find" icon for the search button because that should be theme specific.

Would it be worthwhile to implement the Icons module on Taxonomy Manager? Could it be an optional dependency?

http://drupal.org/project/icon

Anonymous’s picture

Anonymous (not verified) commented

This patch removes all instances of <div class="clear"></div> from the HTML.

In that process, I began to clear up the excessive floating that made the clear class necessary in the taxonomy manager tree. Instead of floating, we can just use inline display.

I also added cursor properties to the term up and term down images.

Anonymous’s picture

Anonymous (not verified) commented

grumble. i'm worried that most of these patches won't be easy to apply because of the inconsistent line endings on this module. i can re-do patches after #298787: coder compliance and mixed LFCR and LF files is fixed.

mh86’s picture

mh86 commented

Hi!
Thanks for working on that. I know, the CSS and HTML got quite complicated during developing.
I'm currently working on re-writing the taxonomy manager tree form element to use drupal-6 new form api features, which is a lot of work to do.
I take a closer look a your patches soon.
And have you been testing the layout in different browsers (if the changes break anything) ?

Matthias

Anonymous’s picture

Anonymous (not verified) commented

I suspect my removal of the clears might break layout, but I gave up when I realized that the patches didn't work because of the inconsistent line endings on the module.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new taxonomy-manager-theme.patch11.27 KB

Rather than re-do all these patches separately, I've combined them into one big patch. Here's the skinny on the patch:

  • The Drupal admin page CSS is used instead of specific widths.
  • All instances of div.clear are gone.
  • Table headers in the term data fieldset have a colspan=2 attribute.
  • Floated divs that hold operations have been made to work with display: inline instead
  • All specified widths, padding, and margin are gone.
  • The throbber enabling script no longer inserts an extra div

From what I can tell, only one display feature has been removed. The term description field now uses the inherited width for resizable text areas, so the save button does not appear to the right of the field.

I may have gone too far, but the stylesheet is much smaller now.

I tested this in Firefox and Safari in Garland, Zen, Bluemarine and my own theme.

I've deleted the prior patches on this issue because they've been superseded by this one.

mh86’s picture

mh86 commented
Status: Active » Fixed

I committed all changes you have done at EOL.
Additionally the small save buttons for the term name and description have been removed (instead using the new 'Save changes' button).
I mark this issue as fixed. If you think we should still change some things, re-open it.
And thanks a lot for the work you have done!

Anonymous’s picture

Anonymous (not verified) commented

mh,

i think this clears up the biggest cross-browser and theme issues

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.