Any time there's a tag-based vocabulary the autocomplete field that is added for it gets added to the page after the fieldsets rather than inside the right one. This is particularly confusing as the code at least looks correct.

CommentFileSizeAuthor
#4 taxonomy_defaults-n515314.patch2.67 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

A fix for taxonomy_defaults.admin.inc, from lines 90 onwards:

    foreach (element_children($form[$type]) as $key) {
      $form[$type][$key]['select']['#title']='';

      $vocabtable[$rowcount][] = drupal_render($form[$type][$key]['name']);
      $vocabtable[$rowcount][] = drupal_render($form[$type][$key]['active']);
      if (isset($form[$type][$key]['tags'])) {
        $vocabtable[$rowcount][] = drupal_render($form[$type][$key]['tags']);
      }
      else {
        $vocabtable[$rowcount][] = drupal_render($form[$type][$key]['select']);
      }
      $vocabtable[$rowcount][] = drupal_render($form[$type][$key]['tip']);
      $rowcount++;
    }

I'll see about doing up a proper patch later.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Closed (won't fix)

Looking at the code in CVS, the separate handling of tags has been removed completely, so this issue is irrelevant.

bradweikel’s picture

bradweikel commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Closed (won't fix) » Active

Damien --

Thanks for your attention to this issue!

I accidentally Included that incomplete code when I rolled the 6.x-1.0 release, and then I removed it again in the head version so there would be a working version.

If you think it's a valuable addition, feel free to roll a full patch against 6.x-1.x-dev, including my broken code in 6.x-1.0 and your fix to that code. I'll come back to this issue soon and consider it for the next release in August.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new taxonomy_defaults-n515314.patch2.67 KB

Here's a patch against CVS, as requested.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
bradweikel’s picture

bradweikel commented
Status: Needs review » Fixed

I've submitted a patch for this to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.