Tags should be displayed based on permissions

This is rather important.

The patch looks good. but it fails. Can you please update it to the latest HEAD?

I'm also getting restricted tags displayed to anonymous and other user groups using the taxonomy access control module

i would also be very interested in this. quite essential for a site with many organic groups. many thanks for looking into it :)

This needs to be improved, or else done a different way. I think we should look at the db_rewrite_sql instead.
This patch will be such a huge performance bottleneck that I cannot consider applying this as it is.

db_rewrite_sql()

Rewrites node, taxonomy and comment queries. Use it for listing queries. Do not use FROM table1, table2 syntax, use JOIN instead.

Can we not simply pass the 'SELECT COUNT(*) AS count ...' trough the db_rewrite_sql()?

There seems to be little interest, throttling down the Priority.

Anyone care to review?

Looks like this does the trick.
I've got e few tags here that I'm not using for the general public.. And there not showing up after the patch.
Can't make statements about the performance though, since I'm not using a lot of tags to organize my posts in ;)

This fine module has made it into the list of modules for my upgrade-project (4.7 -> 5.0)!

Sorry for the duplicate reply, forgot to 'merge' the two screenshots... ;)

Reviewed the code. Its not an option this way:

+  $nodes = db_query(db_rewrite_sql("SELECT n.nid FROM {node} n"));
+  while ($node = db_fetch_object($nodes)) {
+    $allowed[] = $node->nid;
+  }

Imagine what happens when you have 62840 nodes? Innacceptible, this needs a better solution.
1) The overhead: looping trough 100.000 items is not an option.
2) The limit: IN() allows only so much entries, If I am not mistaken, only 255. This solution will trow warnings when you go over that limit.
3) The SQL overhead: an IN() is rather expensive. This slows down stuff a LOT.
4) The SLQ-over-the-Line: your SQL query itself will grow huge requiring a lot of stuff to be passed to-and-from Mysql server: requires a lot of memory.

Subscribing...

Same problem here...
People seeing the tags but no nodes for them...

Any other idea's for fixing this issue ???

Ok, I made it work using db_rewrite_sql() on my 4.7.x-dev instance...
Use this query in the tagadelic_get_weighted_tags() function:

// initial db_rewrite = node; second = term access
  $sql = db_rewrite_sql(db_rewrite_sql('SELECT COUNT(*) AS count, d.tid, d.name, d.vid FROM {term_data} d INNER JOIN {term_node} tn ON d.tid = tn.tid INNER JOIN {node} n ON n.nid = tn.nid WHERE d.vid IN ('. substr(str_repeat('%d,', count($vids)), 0, -1) .') GROUP BY d.tid, d.name, d.vid ORDER BY count DESC'),'tn','tid');
  $result = db_query_range($sql, $vids, 0, $size);

It works... juist make sure you do NOT test it with the admin account... For admins the sql is NOT rewritten... as they can see all...

http://drupal.org/node/132759 was marked duplicate of this issue
http://drupal.org/node/164243 was marked duplicate of this issue

I am closing this issue and merging it with http://drupal.org/node/84095

Continued at http://drupal.org/node/141682