Problem/Motivation

Currently, the logo and favicon values sent are internal relative paths. This can include things like public:// which may be set to a custom path from sites/default/files.

Proposed resolution

Send absolute URLs for these values.

Remaining tasks

  • Create patch for 6.x-1.x
  • Create patch for 7.x-1.x
  • Create patch for 8.x-1.x

User interface changes

None

API changes

None

Data model changes

Sends an absolute URL instead of a relative paths.

CommentFileSizeAuthor
#4 2973454-4-8.x-1.x.patch1.3 KBmarkhalliwell
#2 2973454-2-8.x-1.x.patch1.23 KBmarkhalliwell
#2 2973454-2-7.x-1.x.patch1.14 KBmarkhalliwell
#2 2973454-2-6.x-1.x.patch2.01 KBmarkhalliwell

Comments

markcarver created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2973454-2-6.x-1.x.patch2.01 KB
new 2973454-2-7.x-1.x.patch1.14 KB
new 2973454-2-8.x-1.x.patch1.23 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work

Tested 6.x and 7.x patches on real sites, works fine.

The 8.x patch needs a bit of work though.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed
StatusFileSize
new 2973454-4-8.x-1.x.patch1.3 KB

Here's the correct 8.x-1.x patch (tested it).

  • markcarver committed b0b174a on 8.x-1.x 
    Issue #2973454 by markcarver: Logo and favicon values should be absolute...

  • markcarver committed 5906aa1 on 7.x-1.x 
    Issue #2973454 by markcarver: Logo and favicon values should be absolute...

  • markcarver committed 339b0db on 6.x-1.x 
    Issue #2973454 by markcarver: Logo and favicon values should be absolute...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » markhalliwell
Status: Fixed » Needs work

After thinking about this some more, I think the better option would be to bump the minor API version and introduce two new fields: field_logo_url and field_favicon_url and then deprecate the old ones.

  • markcarver committed 3221954 on 8.x-1.x 
    Revert "Issue #2973454 by markcarver: Logo and favicon values should be...

  • markcarver committed b0a74b9 on 7.x-1.x 
    Revert "Issue #2973454 by markcarver: Logo and favicon values should be...

  • markcarver committed 6d4e844 on 6.x-1.x 
    Revert "Issue #2973454 by markcarver: Logo and favicon values should be...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Closed (won't fix)
Related issues: +#2974946: Refactor into one codebase

Closing in favor of #2974946: Refactor into one codebase.