Hello!

In Drupal 6, CSS files can be overidden by themes using the same css filename. As "tabs.css" is a common file used by themes like Zen, it disables the Jquery UI Tabs.

This is from api.drupal.org on drupal_add_css():

Modules should always prefix the names of their CSS files with the module name, for example: system-menus.css rather than simply menus.css. Themes can override module-supplied CSS files based on their filenames, and this prefixing helps prevent confusing name collisions for theme developers. See drupal_get_css where the overrides are performed.

Easy fix at least ! :)

CommentFileSizeAuthor
#4 tabs-css-patch.patch4.12 KBYaxBalamAhaw

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for the tip. I'll make the change.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

subscribing.

Moonshine’s picture

Moonshine commented

Any chance this change will be made soon ?

Thanks!

YaxBalamAhaw’s picture

YaxBalamAhaw commented
Status: Active » Needs review
StatusFileSize
new tabs-css-patch.patch4.12 KB

Here's a simple patch file the fixes the problem. This is my first time using diff or patch, so let me know if I did something wrong. All it does is rename tabs.css to tabs-tabs.css, and drupal-tabs.css to tabs-drupal-tabs.css, and changes a couple lines of php code to point to the new files.

You would apply the patch by putting the patch file into your tabs module directory and running: patch < tabs-css-patch.patch from that directory (atleast in linux).

danielb’s picture

danielb commented

Patch file works, but it seems the patch file tried to patch itself?

patch < tabs-css-patch.patch
patching file drupal-tabs.css
patching file tabs.css
patching file tabs-css-patch.patch
File tabs-css-patch.patch is not empty after patch, as expected
patching file tabs-drupal-tabs.css
patching file tabs.module
patching file tabs-tabs.css

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Removed tabs.css and moved its contents (one line) to drupal-tabs.css.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.