Problem/Motivation

In MailerTestTrait::assertAddress(), when the assertion fails, actual and expected value are swapped in the output.
This can be confusing.

Steps to reproduce

Proposed resolution

Swap the arguments when calling ->assertEquals().
Rename the parameter to $expected_addresses.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork symfony_mailer-3576956

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

donquixote’s picture

donquixote commented
Version: 2.x-dev » 1.6.2

I notice this is already fixed in 2.x branch!

donquixote opened merge request !202

donquixote changed the visibility of the branch 3576956-assert-expected-actual to hidden.

donquixote changed the visibility of the branch 3576956-assert-expected-actual to active.

donquixote’s picture

donquixote commented
Version: 1.6.2 » 1.x-dev

Let's not rename the parameter.
Too much noise, and it would interfere with named argument calls.

adamps’s picture

adamps commented
Status: Active » Closed (won't fix)

Sorry no backporting except critical/security fixes

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.