Is it possible to auto-switch when a theme is selected and not have the "switch" button?

CommentFileSizeAuthor
#3 switchtheme_autosubmit.patch1.08 KBmrtoner

Comments

KahneFan’s picture

KahneFan commented

Any thoughts?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

If you thought of a onChange-JavaScript-handler for the form select widget, then yes, that would be possible.
However, I don't have time to implement this right now, but would be available for reviewing (and committing) a patch.

mrtoner’s picture

mrtoner commented
Assigned: Unassigned » mrtoner
Status: Active » Needs review
StatusFileSize
new switchtheme_autosubmit.patch1.08 KB

Here it is. I added some <br> tags to keep the <select> from overrunning following blocks; there's probably a better way to do that.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

This needs to degrade if JavaScript is not available. Which means that a patch for this issue most likely does not touch the .module file at all. It just adds a new JavaScript file containing a Drupal.behavior that removes the submit button and attaches the event handler.

On a second thought, I'm not sure whether this will break the layout/functionality of existing sites that use SwitchTheme. Maybe it has to be configurable setting then. Or maybe a notice in the release notes is sufficient... Not sure about that yet.

devin carlson’s picture

devin carlson commented
Status: Needs work » Closed (duplicate)

Marking this as a duplicate of #1406116: Switch form auto-submit because it has a more up-to-date patch.