Switch to non-enabled themes

I like this idea. However, your coding-style needs work, see http://drupal.org/coding-standards for further information.

- Insert a space after the comma to separate array values.
- Use 2 spaces instead of tabs.
- Else is always on the next line, same indent as If.
...if you already read the coding standards section in the handbooks, then read it again, please. All of this is clearly stated there. Either read, understand, and adapt Drupal's coding standards, or do not post patches. Thanks.

Other than that:
- $note is not initialized.
- We do not use dirty HTML hacks like the one in #suffix in Drupal.
- You accidently removed the form submit button in switchtheme_switch_form().

I've noticed on occasion that for anonymous visitors, Switchtheme somehow switched to a theme after the theme has been disabled. It's strange to see this as a feature request.

@christefano: This issue is a feature request. What you are reporting is a completely separate issue. Please open a new bug report for it. Thanks.

@sun: I'm aware that this is a feature request and noted that in my comment. If you prefer that I just write "subscribing" instead please let me know. :)

Any updates?

+++ switchtheme_patch.module	2008-12-15 13:46:29.281250000 +0100
@@ -23,7 +23,7 @@ function switchtheme_help($section) {
+  return array('administer switch', 'switch theme', 'switch to non-enabled themes');

Uhm - why not simply:

s/non-enabled/disabled/ ;)

+++ switchtheme_patch.module	2008-12-15 13:46:29.281250000 +0100
@@ -121,7 +121,8 @@ function switchtheme_switch_form() {
+    '#description' => user_access('switch to non-enabled themes') ? t('Non-enabled themes available') : '',

I don't think this description is of any help...

+++ switchtheme_patch.module	2008-12-15 13:46:29.281250000 +0100
@@ -164,7 +165,10 @@ function switchtheme_options() {
-    if ($attr->status) {
+    if (user_access('switch to non-enabled themes')) {
+      $options[] = $attr-> name;
+    }
+    elseif ($attr->status) {
       $options[] = $attr->name;
     }

Instead, we should store $attr->name as key and "@themename (disabled)" as value for $options here.

Beer-o-mania starts in 20 days! Don't drink and patch.

Is this in the current version of the code? I am able to switch to the Garland theme, even when it is not enabled. I see this as being a problem, so would like to suggest creating a permission to allow someone to switch to a non-enabled theme. I don't want anonymous users to be able to switch to any theme they want.

Thoughts?