Problem/Motivation

The template setting says:
"Enable to exclude this template from the list of formatters on the various places site-wide. Do not forget to reference it on the main template's form."
What abolutely makes sense, because it will result in a JS error when a breakpoint template is choosed in a swiper formatter.

Steps to reproduce

1. Create a template plus connected breakpoint templates
2. Configure a view with the swiper display plugin or a entity reference field with the swiper formatter
3. See the breakpoint templates listed in the template select

Proposed resolution

Hide the breakpoint templates in the formatters template select.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
firefox_m5XdDLWqCZ.png54.29 KBthomas.frobieter
firefox_SaywQLBvUW.png16.72 KBthomas.frobieter
firefox_iJ693jmjU0.png62.54 KBthomas.frobieter

Issue fork swiper_formatter-3572744

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thomas.frobieter created an issue. See original summary.

thomas.frobieter opened merge request !32

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Active » Needs review
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Okay, that was a very simple fix ;) Works for me. Please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks, I'd say that is indeed a bug and a very simply fix. RTBC.

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Hey guys, thx for reporting this issue and proposing a solution!
We'll review as soon as we get the chance.
I think it's a bit of a rush to immediately set it to RTBC, but I'll count u in with "+1 RTBC".

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@bbu23 thanks. RTBC (by community) is not RTBM (by maintainer), so I think this is absolutely okay.

It's always the step BEFORE maintainer review :)

Thank you!!

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

@anybody I agree with you, it is not wrong at all, and I am aware of its meaning.

This status as described here is a judgement call, so it can be very subjective. The reason why I prefer not have the issue marked as RTBC in this situation is because I consider you two as the main author:

You should not generally mark an issue RTBC when you're the sole or main author.

Thank you!

  • bbu23 committed 9cc4f1d2 on 2.1.x 
    test: #3572744 Add kernel tests for breakpoint template filtering

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

Thanks guys!
It will be included in 2.1.0 for now.

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.