Drupal 7 version of Support Ticketing System

Yes, but all in good time. I have no need of a Drupal 7 version of the module at this time, so it's not high on my list of priorities.

If there's anyone out there interested in co-maintaining this module and managing the 7.x branch, please speak up here.

I really need this as well. There's nothing for Drupal 7 yet that i know of.

+1 creating this for D7 would be great moving forwards.

I wouldn't mind managing the 7.x branch

Sam

Anyone looking to co-maintain this project needs to first demonstrate their abilities by writing patches, reviewing patches, and regularly answering support requests through the issue queue.

I will create a 7.x branch from the 1.4 release. I've tagged 1.4-rc1 today -- we'll give people time to test before tagging 1.4 final and creating a 7.x branch.

great news! will test the 1.4 :-)

Bumping this to 7.x version to at least get one active ticket for the D7 version showing up. I'd be interested in helping with patches, but I'm wondering if there's a roadmap worked up anywhere yet? It would be nice not to be duplicating work others have started on.

The only roadmap at this point is to get the 7.x-1.x-dev branch working. The goal is to get it working with the fewest necessary changes (no re-architecting it). Patches are VERY welcome. I started the process, but temporarily ran out of time. I hope to get back to it, but anyone that has time feel free to upload patches. I'll be committing my changes the same day I make them, so you can be fairly confident you're not duplicating effort if you do a 'git pull' before you start working.

We'll create a 7.x-2.x-dev branch after there's a 7.x-1.x release, and in the 2.x branch we'll make better use of Fields/Views/etc.

Here is the right place. Patches would be great! :)

Attempts to apply your patches result in the following error:

   patch: **** Only garbage was found in the patch input.

Ideally please generate your patches with git as documented on this page:
http://drupal.org/patch/create

Implemented support.patch. Received following error when attempting to create ticket : Recoverable fatal error: Argument 2 passed to db_query() must be an array

Making title distinguishable.

The patch failed to apply completely, but it was just the very end that was corrupted so I manually applied it. I then started looking through the patch, here's some feedback:

• The packaging info added by drupal.org should not be committed into the .info file (I removed this)
• The LICENSE should not be added into the repository, that is added by drupal.org
• Clients can be added, but not edited (I thought this was working pre-patch, maybe not)
• You unnecessarily re-wrote a comment in support.install making it more confusing and incorrectly using multi-line comments (I reverted it)
• I removed some unnecessary white space additions / changes (please don't arbitrarily change some indents from 2 spaces to 4 spaces -- when in doubt refer to http://drupal.org/coding-standards).
• Reverted a bunch of incorrect style changes regarding {}, if, and else (see above link) (If your IDE is auto-changing this stuff, you need to reconfigure it or stop using it -- I won't spend this much time again cleaning stuff like this up just so I can find the real changes in your patch)
• Search still needs a lot of work

At this point I've run out of time -- I spent most of the time I had this morning on just re-formatting the code so I could find the actual code changes. It looks like most of the actual patch is good, but I need to review it properly when I have more time.

One quick questions, states are saved as full text, so why this change?

-    'all' => 'all',
-    'all open' => 'all open',
-    'my open' => 'my open',
+    0 => 'all',
+    1 => 'all open',
+    2 => 'my open',

I'm attaching my cleaned up version of your patch. In the future, please do a 'git diff' and confirm that every line of your patch is actually necessary and not just a whitespace change.

Marking as 'needs review' -- I'll probably not be able to return to this until Monday at the earliest.

> My last patch at #23 was not reviewed/applied on your own patch, right ?

Correct. I did not get to the last patch.

I applied both 589552.patch and 589552-comments.patch -- caught a few errors.

I recieve an ajax http errror with autosubscribe + autoassign feature when creating new client.

when trying to edit a support ticket entry and resave, I get the following error :

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '30' for key 'PRIMARY': INSERT INTO {support_ticket} (nid, message_id, state, priority, client, assigned) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => 30 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => 1 [:db_insert_placeholder_3] => 2 [:db_insert_placeholder_4] => 4 [:db_insert_placeholder_5] => 1 ) in _support_node_insert_update() (line 848

Also, the module is not sending any email notifications to users.

Otherwise, things seem to run pretty smooth.

It is definitely getting closer.

Functionally this is looking quite good -- thanks for all your work on this! It took longer to review and commit than I'd like because your editor is still causing formatting regressions with database queries. For example, your patch had:

+      db_update('support_assigned')->fields(array(
+            'active' => 0,
+          ))
+          ->condition('uid', $account->uid)
+          ->condition('nid', $node->nid)
+          ->execute();

Which should instead be formatted:

+      db_update('support_assigned')
+         ->fields(array(
+           'active' => 0,
+         ))
+         ->condition('uid', $account->uid)
+         ->condition('nid', $node->nid)
+         ->execute();

You should never add 4 spaces, only 2. This affected most all the database queries your patch touches (db_update, db_select, db_insert and db_delete).

Note that comment_upload will not exist for Drupal 7, so to support attachments on ticket updates we'll need to add support for the Field API -- I think this can be done under a separate ticket after the base functionality is working.

The code in support_query_alter was commented out and flattened -- you mention earlier in this thread that you've not yet looked at the search functionality.

Committed #27 and #33. Please re-sync your latest patch, and be sure that your editor isn't adding 4 spaces to database queries. You can see what has been committed here:
http://drupalcode.org/project/support.git/commitdiff/2cb61e6

Please be sure to run 'git diff' to avoid letting unnecessary white space changes happen, for example:


- 'data' => t('No tickets available.'),
- 'colspan' => count($header),
- ));
+ 'data' => t('No tickets available.'),
+ 'colspan' => count($header),
+ ));


There was only one reject, and it's actually wrong. Instead of doing a select to determine whether to do an insert or update, you should instead use db_merge (see http://drupal.org/node/310085). I've made this change. See the full commit here:
http://drupalcode.org/project/support.git/commitdiff/f16893b

This is great, thanks for your continued effort on this! The support module is nearly usable on Drupal 7 at this point. :)

It has come a long way in the last week, that's for sure! The biggest missing feature is the email notification bit, but most everything else is up and running at least.

Lost track of the thread here. Which of the patches and/or commits are current? Or should I start with a fresh 7.x?

Not getting any email updates when I create or alter a ticket at all. I am trying to figure out if I missed a patch.

Worked on this today.

commit 75a22739ddfd008a6e6090142e7dd0a8806aa4d6
Author: Brandon Bergren
Date: Thu Apr 28 17:47:32 2011 -0500

Fix autocomplete queries.
There's still an issue with them -- they don't work for permissions assigned to anonymous / authenticated user roles!
This is not a 7.x specific bug however.

commit e3aac74e47e5386ecb3eeb4b68f121ce31d6d9ad
Author: Brandon Bergren
Date: Thu Apr 28 17:15:04 2011 -0500

Fix the select-all checkbox.

commit 0368acce9e0fde3b88fe5d5b74b4742dc6969e26
Author: Brandon Bergren
Date: Thu Apr 28 16:59:47 2011 -0500

Fix header sorting.

commit 934f79e22395ef2b10c4d73f38cd8171d48aaf15
Author: Brandon Bergren
Date: Thu Apr 28 15:53:35 2011 -0500

Fix permission name in previous.

commit f78f06cb09596fcb27a388ffe019b28628b4ede6
Author: Brandon Bergren
Date: Thu Apr 28 15:46:39 2011 -0500

Issue #1139946 by miro_dietiker: Fix early return in hook_permission() that
was causing the client permissions to disappear.

@javier.alejandro.castro:
heads up, I just rewrote the broken support_node_access() to actually work, so access control on individual tickets should be working now (hopefully.)
9a9dedcfda24b94d2ee36bc42fe2740f6c31d0ae

(This is unrelated to the access control that is applied to queries, but affects stuff like directly going to node/nnn)

@javier.alejandro.castro:
I just patched up some stuff in the front end part of the search that was preventing the form from working correctly.
4080434e97daeacef72139de446c508ecade041e

Initial port of support_overview.module committed.
38b1539b998765aed64097ab291b8a6c6dc952c1

Initial port of support_charts.module committed.
41cfaf06ffd37df1ed4e5554bf3f90846182d670

support2.patch (reverse) committed as is.

I merged support1.patch with some local fixes and then debugged the rest of support_search_execute(). Search seems to actually be working

@javier.alejandro.castro: Please review 29e1f6eb9d58671b0b02a78268a2923cd8a162f1 -- The logic is a lot simpler now, I rewrote it again based on how node_search_execute changed.

@javier.alejandro.castro: Figured out what the $enabled_states[0] stuff was about -- there's an option in the admin ui when setting the variable for 'all', and this key of this choice is 0. I just pushed some minor changes in support_overview that should make this more obvious.

WIP patch for submission via email and upload field work.

Warning: upgrade path has not been tested with the current code.

It might work, might not, but I'm mainly dumping it here because A) it's too late to get in tonight, and B) there's a possiblity I may need to leave suddenly for a few days. (relative hospitalized)

@javier.alejandro.castro:

Committed the missing t()s, thanks. (3dfc2db013505b15b15eef64eff75c6cf59f74c7) However, PO files no longer go in the repository. I suggest signing up at http://localize.drupal.org/ (There are some good instructions at http://drupal.org/node/302194 )

Heads up: I just pushed a huge update that I've been working on for a couple weeks.

Closing meta ticket; rolling release candidate.

como coño se descarga esta mierda drupal de la mujer del pelotero

Still looking for an upgrade path from 6.x to 7.x for this module. Any word on it?

Please test an upgrade and open bugs if you run into problems. There's no reason to think everything will break on upgrade, and no way it's going to get fixed if upgrade errors aren't reported.

Be sure to test on a backup of your website! And please report errors in new tickets, don't reopen this old one.